Closed Bug 1185933 Opened 9 years ago Closed 9 years ago

Enhancing options like browser.safebrowsing.malware.enabled

Categories

(Toolkit :: Safe Browsing, defect)

39 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 874408

People

(Reporter: sworddragon2, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0 Build ID: 20150629110007 Actual results: Options like browser.safebrowsing.malware.enabled are currently providing only the ability to completely disable the related feature or to enable it + activating external communication (for example downloading an up-to-date list). Expected results: Maybe these options could provide an additional value in about:config. false would then map to 0 (feature is disabled) while true would map to 2 (feature is enabled + external communication is enabled). The value 1 would then be used to only enable the feature without any external communication. Additional informations: A use case could be for users who actually don't dislike the related feature but don't trust the connection to a provider like Google. There may also be some minor use cases like complex user setups, etc.
Blocks: 329292, 1149867
Component: Untriaged → Safe Browsing
Product: Firefox → Toolkit
Safe Browsing doesn't work without a regular connection to the external provider: - The lists are downloaded every 30 minutes. They expire after 45 minutes if the update hasn't happened. - The list of malware / phishing site is a list of partial URL hashes (the first 32 bits of a SHA-256 hash). When you have a partial match, you need to download the full hashes for that hash prefix. So I'm not sure exactly what you're suggesting.
I don't know how safebrowsing is working in detail with these hashes. But this issue is not only about the 2 safebrowsing options but about any option that matches such a behavior. For example this would also match the blocklists but I'm thinking the developers are better knowing than me about a full list of the related options.
The add-on blocklist is a completely different mechanism so it would need a separate bug. It doesn't share any code with this. For the Safe Browsing list, I don't understand your suggestion so I don't think we'll be able to do anything about it.
(In reply to sworddragon2 from comment #2) > But this issue is not only about the 2 safebrowsing options but about any > option that matches such a behavior. Removing the blocked bugs since it's more general than that.
No longer blocks: 1149867, 329292
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.