Julien Wajsberg [:julienw] Assignee
	Description • 9 years ago

      No description provided.

	Julien Wajsberg [:julienw] Assignee
	Comment 2 • 9 years ago

Comment on attachment 8636663 [details]
[gaia] julienw:1185983-refactor-focus-handling > mozilla-b2g:master

Tell me what you think ! I added some comments on github to help reading the patch.

The focus handling in the Recipients panel is quite messy as well but I think this is out of the scope of this patch and could be a separate patch by itself.

	Oleg Zasypkin [:azasypkin]
	Comment 3 • 9 years ago

Comment on attachment 8636663 [details]
[gaia] julienw:1185983-refactor-focus-handling > mozilla-b2g:master

Looks really nice! But it seems one case is missed - when we open conversation with draft from Inbox view or notification, message input is focused on master, but not with the patch.

Would be great to have tiny integration test for this case if possible, but won't block on this :)

Thanks!

	Julien Wajsberg [:julienw] Assignee
	Comment 4 • 9 years ago

Comment on attachment 8636663 [details]
[gaia] julienw:1185983-refactor-focus-handling > mozilla-b2g:master

Hey,

I think I covered your comments now, it's all in a separate commit :)
Tell me what you think :)

	Oleg Zasypkin [:azasypkin]
	Comment 5 • 9 years ago

Comment on attachment 8636663 [details]
[gaia] julienw:1185983-refactor-focus-handling > mozilla-b2g:master

Can't find any issues now, looks good!

Please, make sure that new "number" activity case works as well :) I could not test it because of startup crash in Contacts app (bug 1186920) for all my Flames.

Thanks!

	Julien Wajsberg [:julienw] Assignee
	Comment 6 • 9 years ago

master: 73ab548325594b629a46b2eb846981fa75296bda

thanks !