Closed
Bug 1186042
Opened 9 years ago
Closed 9 years ago
"Undeclared identifier" errors building nsAboutBloat.cpp
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: smichaud, Assigned: smichaud)
References
Details
Attachments
(1 file)
(deleted),
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
In file included from /usr/local/src/Mozilla/mozilla-central/obj-firefox-64bit/netwerk/protocol/about/Unified_cpp_protocol_about0.cpp:11:
/usr/local/src/Mozilla/mozilla-central/netwerk/protocol/about/nsAboutBloat.cpp:94:9: error: unknown type name 'PRExplodedTime'
PRExplodedTime expTime;
^
libother-licenses_snappy.a.desc
rm -f libother-licenses_snappy.a
/usr/local/src/Mozilla/mozilla-central/netwerk/protocol/about/nsAboutBloat.cpp:95:24: error: use of undeclared identifier 'PR_Now'; did you mean 'JS_Now'?
PR_ExplodeTime(PR_Now(), PR_LocalTimeParameters, &expTime);
^~~~~~
JS_Now
../../../dist/include/jsapi.h:937:1: note: 'JS_Now' declared here
JS_Now(void);
^
/usr/local/src/Mozilla/mozilla-central/obj-firefox-64bit/_virtualenv/bin/python /usr/local/src/Mozilla/mozilla-central/config/expandlibs_gen.py -o libother-licenses_snappy.a.desc Unified_cpp_snappy0.o
In file included from /usr/local/src/Mozilla/mozilla-central/obj-firefox-64bit/netwerk/protocol/about/Unified_cpp_protocol_about0.cpp:11:
/usr/local/src/Mozilla/mozilla-central/netwerk/protocol/about/nsAboutBloat.cpp:95:34: error: use of undeclared identifier 'PR_LocalTimeParameters'
PR_ExplodeTime(PR_Now(), PR_LocalTimeParameters, &expTime);
I see these on the Mac, doing my own self builds. But I expect they can happen on all platforms. I have no idea why this bug hasn't broken Mozilla's own m-c nightly builds -- it really should have.
This bug was triggered by the patches for bug 905127.
The fix is very simple. I'll post it in my next comment.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → smichaud
Assignee | ||
Comment 1•9 years ago
|
||
Apparently bug 905127 changed nsNetUtil.h so that it no longer includes prtime.h, even indirectly. But all we need is prtime.h, so we should just include that directly.
Attachment #8636628 -
Flags: review?(jduell.mcbugs)
Updated•9 years ago
|
Attachment #8636628 -
Flags: review?(jduell.mcbugs) → review+
Comment 2•9 years ago
|
||
Are you using non-unified builds, by chance?
Assignee | ||
Comment 3•9 years ago
|
||
I see the same errors whether nsAboutBloat.cpp is part of a unified build or not.
Assignee | ||
Comment 4•9 years ago
|
||
I didn't try disabling unified builds altogether, though.
Assignee | ||
Comment 6•9 years ago
|
||
But yes, I see how using unified builds might have papered over this bug.
I suppose we should do totally non-unified builds periodically on our official build machines, just to uncover bugs like this.
Assignee | ||
Comment 7•9 years ago
|
||
Another thing: Almost all my builds are from-scratch. That my be why I always saw this bug.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•