Closed
Bug 1186154
Opened 9 years ago
Closed 9 years ago
Templatize the RootingContext in the Rooted constructor
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
The universal constructor Jon recommended in bug 1185749 worked like a charm. We can do something similar for the context parameter as well and save ourselves even more copy-paste.
Attachment #8636752 -
Flags: review?(jcoppeard)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8636752 [details] [diff] [review]
universal_rooted_constructor-v0.diff
Review of attachment 8636752 [details] [diff] [review]:
-----------------------------------------------------------------
Nice!
Attachment #8636752 -
Flags: review?(jcoppeard) → review+
|
||
Comment 3•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•