Closed Bug 1186471 Opened 9 years ago Closed 7 years ago

Highlighted result in the Awesomebar-results-pane flickers, when deleting letters from the Location-bar via Delete key

Categories

(Firefox :: Address Bar, defect, P3)

42 Branch
defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: mehmet.sahin, Unassigned)

References

Details

(Whiteboard: [unifiedcomplete][fxsearch])

Attachments

(1 file)

(deleted), video/quicktime
Details
Attached video flicker.mov (deleted) —
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:42.0) Gecko/20100101 Firefox/42.0 Build ID: 20150722030205 Steps to reproduce: Nightly Build: 42.0a1 (2015-07-22) OSX 10.10.4 1.) Type something into the Location-bar, what is also in your history or a bookmark. 2.) It will be autocompleted and you see the blue highlight in the list. 3.) Delete the letters via Delete key in the Location-bar. Actual results: The blue highlight flickers. Expected results: It should not flicker.
Status: UNCONFIRMED → NEW
Component: Untriaged → Location Bar
Ever confirmed: true
Flags: firefox-backlog+
Priority: -- → P2
Whiteboard: [unifiedcomplete][fxsearch]
Same also happens in the searchbar. Probably all "autocomplete" widgets have this problem.
This happens because each time you delete a letter, the location bars starts a new search. not sure about this to fix or not
it is the same when adding letters, we fixed it through some timeouts. Likely we can do something for this too. Note the searchbar could require a separate bug, since it's not using a richlistbox nor having pre-selection.
The solution should be the same: instead of directly wiping the list, wipe only at the start of receiving the new data.
(In reply to Marco Bonardo [::mak] from comment #3) > Note the searchbar could require a separate bug, since it's not using a > richlistbox nor having pre-selection. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1186975 for the Searchbar issue.
(In reply to Alfred Kayser from comment #4) > The solution should be the same: > instead of directly wiping the list, wipe only at the start of receiving the > new data. yes but autocomplete using trees and the ones using richlistbox follow different code paths. it's also not fine to wait for new data, since new data could take a lot of time to arrive or never arrive. That's why for richlistbox case we went for a timeout.
Rank: 31
Priority: P2 → P3
It's rarely reproducible for me using your STR. I think, the case isn't deleting autocomplete itself. I reproduced it on Win7 with these steps: 1. Type/paste "lkjlkjlkjlkjlkjlkjlkjlkjlkjlkj" into the Location-bar 2. Ensure that cursor is placed after the last character AND there's no selection or autocomplete 3. Press BackSpace several times In bug 1186975, I could modify step 3 to "Press {Left, then Delete} several times" or "Press {Shift+Left, then Delete/BackSpace/Ctrl+X} several times"
(correct Step 3) 3.* Press BackSpace several times (with an interval of ~2 seconds)
I can't reproduce it any longer in FF58. I think the Awesome Bar Result List design/code has been changed. Can this report be closed?
yes, we indeed changed the location bar populating mode to reduce flicker.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: