Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 9 years ago

STR:

1. Set focus to a contenteditable element (e.g., tweet input box of twitter.com)
2. Click outside of the editor

Then, composition string should be committed and IME selection has gone.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 1 • 9 years ago

Oops, this is not an e10s-specific bug...

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 2 • 9 years ago

Hmm, this regression has been already released :-(

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 3 • 9 years ago

Hmm, the cause of this bug is, selection is moved by mousedown. The selection is in non-editable element. Then, nsHTMLEditRules::IsModifiableNode() returns false and nsHTMLEditRules::WillDoAction() fails to modify the existing composition.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 4 • 9 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f11d88407ad2

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 5 • 9 years ago

Hmm, look like that Ehsan is on vacation or something. Smaug, could you review this?

nsEditorEventListener::MouseDown() calls mEditor->ForceCompositionEnd() for committing composition when user clicks in the focused editor.

However, in HTML editor case, user may click outside of the focused editor. In such case, nsHTMLEditorEventListener::MouseDown() doesn't call nsEditorEventListener::MouseDown(). Therefore, if mousedown event is fired outside of the editor, i.e., htmlEditor->IsAcceptableInputEvent(aMouseEvent) returns false, nsHTMLEditorEventListener should call mEditor->ForceCompositionEnd() by itself.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 6 • 9 years ago

This test checks if IME selections are correctly removed at committing composition.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 7 • 9 years ago

CCing Ehsan, although, he may be on vacation or something.

	Olli Pettay [:smaug][bugs@pettay.fi]
	Comment 8 • 9 years ago

Comment on attachment 8644813 [details] [diff] [review]
part.1 nsHTMLEditorEventListener should commit composition when it receives unacceptable mousedown event

I would just call nsEditorEventListener::MouseDown(aMouseEvent);
which happens to do exactly the same thing.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 9 • 9 years ago

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8ad9b87bac4da23ff549ecb2d2b602341f769f40
changeset:  8ad9b87bac4da23ff549ecb2d2b602341f769f40
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 08 09:23:04 2015 +0900
description:
Bug 1186799 part.1 nsHTMLEditorEventListener should commit composition when it receives unacceptable mousedown event r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e0a8c1d52ab9e0fa0bf133350e096b9400d8e0fd
changeset:  e0a8c1d52ab9e0fa0bf133350e096b9400d8e0fd
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 08 09:23:04 2015 +0900
description:
Bug 1186799 part.2 Add test to check if IME selections are removed by committing composition caused by clicking outside of the focused contenteditable editor r=smaug

	Phil Ringnalda (:philor)
	Comment 10 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/8ad9b87bac4d
https://hg.mozilla.org/mozilla-central/rev/e0a8c1d52ab9