Closed
Bug 1186832
Opened 9 years ago
Closed 9 years ago
"File not found" issue when running "multiple-register.https.html" test
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox42 affected, firefox43 fixed)
RESOLVED
FIXED
mozilla43
People
(Reporter: noemi, Assigned: nsm)
References
Details
Attachments
(1 file)
Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/multiple-register.https.html|
Actual Result:
"File not found"
Firefox can't find the file at https://web-platform.test:8443/_mozilla/service-workers/service-worker/out-of-scope.
|
Reporter | |
Updated•9 years ago
|
Component: DOM: Service Workers → web-platform-tests
Product: Core → Testing
|
Assignee | |
Comment 1•9 years ago
|
||
1186832 - Fix multiple-register.https.html test. r?bkelly,jgraham
Standard scope comparison stuff for the most part. Added <body> tag so
document.body.appendChild() in with_iframe() works. I had to add a simple 404
script because <iframe> apparently only fires the onload event if the
content-type was text/plain or text/html but our test harness delivers JSON by
default leading to timeouts.
Update web-platform-tests expected data
Attachment #8654437 -
Flags: review?(james)
Attachment #8654437 -
Flags: review?(bkelly)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8654437 [details]
MozReview Request: 1186832 - Fix multiple-register.https.html test. r?bkelly,jgraham
https://reviewboard.mozilla.org/r/17689/#review15855
Attachment #8654437 -
Flags: review?(bkelly) → review+
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8654437 [details]
MozReview Request: 1186832 - Fix multiple-register.https.html test. r?bkelly,jgraham
I'm happy that bkelly reviewed this correctly :)
Attachment #8654437 -
Flags: review?(james) → review+
|
|
||
Updated•9 years ago
|
Attachment #8654437 -
Flags: review+ → review-
|
|
||
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/17689/#review15977
::: testing/web-platform/mozilla/tests/service-workers/service-worker/multiple-register.https.html:25
(Diff revision 1)
> - 'register should resolve to the same worker');
> + assert_equals(new_registration.scope, registration.scope,
Given bug 1181039 comment 11, I don't think this is correct any more. It seems the spec does require registration equality.
|
|
Assignee | |
Comment 5•9 years ago
|
||
Ben, would you be ok if I landed this and then we fixed it all in bug 1201127?
Flags: needinfo?(bkelly)
|
|
||
Comment 6•9 years ago
|
||
Sounds good. Can you leave a TODO comment in the test at least?
Flags: needinfo?(bkelly)
|
|
Assignee | |
Comment 8•9 years ago
|
||
|
||
Comment 9•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
|
Reporter | |
Comment 10•9 years ago
|
||
Hi,
Just checked on m-c (691b1524602d revision) and the tests successfully run. Thanks for fixing it!.
Summary
Harness status: OK
Found 3 tests
3 Pass
Details
Result Test Name
Pass Subsequent registrations resolve to the same registration object
Pass Subsequent registrations from a different iframe resolve to the different registration object but they refer to the same registration and workers
Pass Concurrent registrations resolve to the same registration object
You need to log in
before you can comment on or make changes to this bug.
Description
•