Closed Bug 1186886 Opened 9 years ago Closed 9 years ago

Fullscreen browser has misplaced command button cutout

Categories

(Core :: Widget: Win32, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla42
Tracking Status
firefox39 --- unaffected
firefox40 + verified
firefox41 + fixed
firefox42 + verified

People

(Reporter: jimm, Assigned: jimm)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Attached image black cutout (deleted) —
STR: 1) open nightly to about blank 2) hit f11 to get into fullscreen result: see screenshot of the top of the window at the display edge [Tracking Requested - why for this release]: bad drawing regressions related to windows 10 command button work.
There's a good chance this is out on aurora and beta too, or at least might be headed there through uplifts.
Keywords: qawanted
[Tracking Requested - why for this release]: affected aurora41.0a2 and beta40 latest tinderbox build
Tracking Windows 10 regression. ni dolske and smooney as we need to get someone on this immediately.
Flags: needinfo?(smooney)
Flags: needinfo?(dolske)
Assignee: nobody → jmathies
Attached patch patch (obsolete) (deleted) — Splinter Review
That early return we added without setting the clear region caused this. Comments in the patch explain the changes.
Attachment #8638103 - Flags: review?(jaws)
Comment on attachment 8638103 [details] [diff] [review] patch Review of attachment 8638103 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/windows/nsWindow.cpp @@ +3724,4 @@ > nsIntRegion clearRegion; > if (!HasGlass() || !nsUXThemeData::CheckForCompositor()) { > + // Make sure and clear old regions we've set previously. Note HasGlass can be false > + // for glass desktops if the window we are rendering too doesn't make use of glass. s/too/to/ I'd also say "doesn't make use of glass (e.g. fullscreen browsing)".
Attachment #8638103 - Flags: review?(jaws) → review+
Status: NEW → ASSIGNED
Flags: needinfo?(smooney)
Flags: needinfo?(dolske)
Attached patch patch v.2 (deleted) — Splinter Review
updated, thanks.
Attachment #8638103 - Attachment is obsolete: true
Attachment #8638118 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Flags: qe-verify+
QA Contact: cornel.ionce
ni Florin to see if his team can verify this fix on Nightly so that we can consider it for uplift for beta8. jimm - What do you think about uplifting this fix for beta8?
Flags: needinfo?(jmathies)
Flags: needinfo?(florin.mezei)
Confirming the fix on Windows 10 64-bit using latest Nightly, build ID: 20150726030217.
Status: RESOLVED → VERIFIED
Flags: needinfo?(florin.mezei)
Keywords: qawanted
(In reply to Cornel Ionce [QA] from comment #11) > Confirming the fix on Windows 10 64-bit using latest Nightly, build ID: > 20150726030217. The bug was on non-windows 10 systems?
Flags: needinfo?(jmathies)
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(cornel.ionce)
(In reply to Lawrence Mandel [:lmandel] (use needinfo) from comment #10) > ni Florin to see if his team can verify this fix on Nightly so that we can > consider it for uplift for beta8. > > jimm - What do you think about uplifting this fix for beta8? I don't think we have a choice since it's such an obvious drawing bug that impacts our most popular operating system.
Comment on attachment 8638118 [details] [diff] [review] patch v.2 Approval Request Comment [Feature/regressing bug #]: regression from bug 1173725 [User impact if declined]: ugly drawing bug in main browser ui [Describe test coverage new/current, TreeHerder]: very little since it's a platform feature. fix is on mc. [Risks and why]: low, cosmetic in nature. We're not going to break anything major with this change. [String/UUID change made/needed]: none
Attachment #8638118 - Flags: approval-mozilla-beta?
Attachment #8638118 - Flags: approval-mozilla-aurora?
Comment on attachment 8638118 [details] [diff] [review] patch v.2 Fix is verified and the issue is very user visible. We'll take the fix in beta8. Beta+ Aurora+
Attachment #8638118 - Flags: approval-mozilla-beta?
Attachment #8638118 - Flags: approval-mozilla-beta+
Attachment #8638118 - Flags: approval-mozilla-aurora?
Attachment #8638118 - Flags: approval-mozilla-aurora+
I've reproduced this issue on Firefox 40 beta 7, buildID 20150723165742. I've also tested on Windows 7 x64 and Windows 8.1 x86. Confirming the fix for 40 beta 8, build ID: 20150727174134
Flags: needinfo?(cornel.ionce)
Flags: qe-verify?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: