magicp Reporter
	Description • 9 years ago

User Agent: Mozilla/5.0 (Windows NT 6.3; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20150723030207

Steps to reproduce:

See Also: Bug 1180688

Case #1
layers.offmainthreadcomposition.enabled = true
layers.acceleration.disabled = false
- XUL documents      [OK]
- HTML documents    [NG]

Case #2
layers.offmainthreadcomposition.enabled = false
layers.acceleration.disabled = false
- XUL documents      [OK]
- HTML documents    [NG]

Case #3
layers.offmainthreadcomposition.enabled = false
layers.acceleration.disabled = true
- XUL documents      [OK]
- HTML documents    [OK]

My environment:
- Nightly 42.0a1 (20150721030212) and later
- Mac OS X 10.6.8 (Guest OS) in VirtualBox 4.3.30


Actual results:

HTML document rendering doesn't work with multi-processs on OSX 10.6.8 in VirtualBox.
Please find the attached image "test case 1-2.png"


Expected results:

HTML document rendering should work with multi-process on OSX 10.6.8 in virtual environment.

	Kamil Jozwiak [:kjozwiak]
	Comment 1 • 9 years ago

Reproduced using the following m-c build on a VM running OSX 10.7.5:
* https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2015-07-24-03-02-10-mozilla-central/

	Markus Stange [:mstange] Assignee
	Comment 2 • 9 years ago

Yes, this is not surprising.

We'll fix BasicCompositor to work in VMs before we'll be ready to ship e10s.

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 4 • 9 years ago

Brad, should this be blocking e10s release, and if so, which bug?

	Brad Lassey [:blassey] (use needinfo?)
	Comment 5 • 9 years ago

This is probably a product question.

	:Felipe Gomes (needinfo for replies!)
	Comment 6 • 9 years ago

Sorry about sending this back to triage again. I'm renom'ing it because it's not clear in this bug, but this means that Safe Mode doesn't work with e10s on OSX.
Perhaps the solution could be different than fixing the basic compositor (e.g., don't disable OMTC in safe mode?), but we definitely need to ship with a working safe mode..

	Brad Lassey [:blassey] (use needinfo?)
	Comment 7 • 9 years ago

Milan, so safe mode uses the basic compositor. One question is if we still think that safe-mode needs to do it? If so, we should probably fix the basic compositor.

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 8 • 9 years ago

Right, what bug should this block so that it's tracked as blocking e10s?  Or is just tracking-e10s+ that's enough?

This, based on the old conversation that e10s+safe mode is a required configuration, as in, safe-mode should not turn off e10s.  If that changes, we won't care about this bug. 

In the meantime, for tracking, this should be tracked for the e10s release, so let's start with 45, as that's the newest release we can currently track.

	Erin Lancaster [:elan]
	Comment 9 • 9 years ago

Product Triage: We should be able to render web pages in safe mode before we go GA. Definitely blocks.

	Brad Lassey [:blassey] (use needinfo?)
	Comment 10 • 9 years ago

to the question of how to track, anything in a milestone is tracked for release. Putting this in m8. Milan, do you have an assignee?

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 11 • 9 years ago

Sounds like Markus has a beginning of a patch for this already.

	Markus Stange [:mstange] Assignee
	Comment 14 • 9 years ago

Review commit: https://reviewboard.mozilla.org/r/28965/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28965/

	Markus Stange [:mstange] Assignee
	Comment 15 • 9 years ago

Oh, the commit message should be "Don't require accelerated OpenGL contexts for BasicCompositor on OS X." instead.

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 16 • 9 years ago

https://reviewboard.mozilla.org/r/28965/#review25725

::: gfx/gl/GLContextProviderImpl.h:43
(Diff revision 1)
> -    CreateForWindow(nsIWidget* widget);
> +    CreateForWindow(nsIWidget* widget, bool aForceAccelerated = false);

Is it worth not having the default value for the aForceAccelerated parameter, so that the callers have to understand the options?

	Markus Stange [:mstange] Assignee
	Comment 17 • 9 years ago

Ok, sure.

	Markus Stange [:mstange] Assignee
	Comment 18 • 9 years ago

Comment on attachment 8701453 [details]
MozReview Request: Bug 1187322 - Don't require accelerated OpenGL contexts for BasicCompositor on OS X. r?jrmuizel

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/28965/diff/1-2/

	Jeff Muizelaar [:jrmuizel]
	Comment 19 • 9 years ago

Comment on attachment 8701453 [details]
MozReview Request: Bug 1187322 - Don't require accelerated OpenGL contexts for BasicCompositor on OS X. r?jrmuizel

https://reviewboard.mozilla.org/r/28965/#review25943

	Pulsebot
	Comment 20 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b3b26d05cf

	Pulsebot
	Comment 21 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/969eb8802928

	Carsten Book [:Tomcat]
	Comment 22 • 9 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/c0b3b26d05cf
https://hg.mozilla.org/mozilla-central/rev/969eb8802928

	Sylvestre Ledru [:Sylvestre]
	Comment 23 • 9 years ago

Markus, can we have an uplift request to aurora (45)? thanks

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 24 • 9 years ago

(In reply to Sylvestre Ledru [:sylvestre] from comment #23)
> Markus, can we have an uplift request to aurora (45)? thanks

This caused a regression (bug 1236282), so let's make sure we don't uplift until that's cleared.

	Sylvestre Ledru [:Sylvestre]
	Comment 25 • 9 years ago

Milan, looks like that bug 1236282 is fixed, should we uplift this one (with the other bug) or let it ride the train from 46? Thanks

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 26 • 9 years ago

This should be with E10S, as it messes up the safe mode.  I would prefer it just rode the trains, but Brad can comment if we need it in 45.

	Brad Lassey [:blassey] (use needinfo?)
	Comment 27 • 9 years ago

(In reply to Milan Sreckovic [:milan] from comment #26)
> This should be with E10S, as it messes up the safe mode.  I would prefer it
> just rode the trains, but Brad can comment if we need it in 45.

We're testing e10s in beta 45. Does this endanger non-e10s? If not I'm leaning towards uplifting.

	Milan Sreckovic [:milan] (needinfo for best results)
	Comment 28 • 9 years ago

I don't know about "endanger", but the code change applies to non-e10s, yes.  If we're going to unleash this on all of 45 beta, then we should probably uplift.

	Brad Lassey [:blassey] (use needinfo?)
	Comment 29 • 8 years ago

Comment on attachment 8701453 [details]
MozReview Request: Bug 1187322 - Don't require accelerated OpenGL contexts for BasicCompositor on OS X. r?jrmuizel

Requesting uplift per milan's comment 28

Approval Request Comment
[Feature/regressing bug #]:
[User impact if declined]: e10s beta experiment users may not get content rendered 
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

	Markus Stange [:mstange] Assignee
	Comment 30 • 8 years ago

I still haven't found a way of fixing the crashes that this patch caused, see bug 1236359. I don't recommend uplifting it at this point.

	Sylvestre Ledru [:Sylvestre]
	Comment 31 • 8 years ago

Comment on attachment 8701453 [details]
MozReview Request: Bug 1187322 - Don't require accelerated OpenGL contexts for BasicCompositor on OS X. r?jrmuizel

Let's take it.

	Ryan VanderMeulen [:RyanVM]
	Comment 32 • 8 years ago

Comment on attachment 8701453 [details]
MozReview Request: Bug 1187322 - Don't require accelerated OpenGL contexts for BasicCompositor on OS X. r?jrmuizel

This shouldn't land on 45 until bug 1241665 is ready for uplift as well.

	Sylvestre Ledru [:Sylvestre]
	Comment 33 • 8 years ago

Comment on attachment 8701453 [details]
MozReview Request: Bug 1187322 - Don't require accelerated OpenGL contexts for BasicCompositor on OS X. r?jrmuizel

The other patch landed.

	Carsten Book [:Tomcat]
	Comment 34 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/4b11c07f23eb
https://hg.mozilla.org/releases/mozilla-aurora/rev/2479bafc6db4