Daniel Holbert [:dholbert] Reporter
	Description • 9 years ago

STR:
 1. Start typing something in the search bar.
 2. Inspect the dropdown that appears.

ACTUAL RESULTS:
* There's a dark background on the suggested search terms & the search engine list.
* In contrast, there's a light background on the other panels -- the headers w/ name of current search engine, "Search for [...] with:", and the "Change Search Settings" at the bottom.
* So this creates a weird alternating stripey-looking pattern.

Before the switch to GTK3, this dropdown had all basically the same background color (with maybe a subtle variation).

I'm using Nightly 42.0a1 (2015-07-24) with Ubuntu 15.04 & gnome-shell.

	:Gijs (he/him)
	Comment 4 • 9 years ago

Even on GTK2 the colors on a non-dark theme are grey vs. white, so it doesn't really surprise me as much that on a dark theme they would be black vs. white. Anyhow, I'm investigating how we style this and if/how we can do better (or if gtk3 is giving us the wrong thing for a system color, or something).

	:Gijs (he/him)
	Comment 5 • 9 years ago

Florian, looks like we hardcode the header colors, and the tree is left themed. Can we use theme colors for the headers as well?

	Florian Quèze [:florian]
	Comment 6 • 9 years ago

(In reply to :Gijs Kruitbosch from comment #5)
> Florian, looks like we hardcode the header colors, and the tree is left
> themed. Can we use theme colors for the headers as well?

There was a WIP for this in bug 1106569. Unfortunately, it didn't land because it also attempted to do a larger refactoring (css de-duplication) at a time when we were still uplifting plenty of searchbox patches.

	Florian Quèze [:florian]
	Comment 8 • 9 years ago

Comment on attachment 8661615 [details] [diff] [review]
1187393.patch

Review of attachment 8661615 [details] [diff] [review]:
-----------------------------------------------------------------

The code changes look reasonable. I don't have access to my Linux machine right now to test, but I assume you made it look either like attachment 8638634 [details], or like something seeming more native. A screenshot would be nice.

::: browser/themes/linux/searchbar.css
@@ +84,5 @@
>    -moz-box-align: center;
>  }
>  
>  .search-panel-current-engine {
> +  border-bottom: 1px solid rgba(0, 0, 0, 0.2);

Is the reason for using a hardcoded color here (rather than a value from the theme, like for example threedlightshadow, as the WIP did in bug 1106569) that you need this color to match the color in the png file used for the background image of .searchbar-engine-one-off-item ?

	Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin] Assignee
	Comment 9 • 9 years ago

(In reply to Florian Quèze [:florian] [:flo] from comment #8)
> Is the reason for using a hardcoded color here (rather than a value from the
> theme, like for example threedlightshadow, as the WIP did in bug 1106569)
> that you need this color to match the color in the png file used for the
> background image of .searchbar-engine-one-off-item ?

That, and they don't fit with the menu colour in the theme(s) I tried. In the default Ubuntu theme, for instance, all of the ThreeD*Shadow colours are far too light.

Screenshots attached.

	Florian Quèze [:florian]
	Comment 10 • 9 years ago

(In reply to Edwin Flores [:eflores] [:edwin] from comment #9)

Ok, thanks! :-)

	Pulsebot
	Comment 11 • 9 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfb0223e3093

	Carsten Book [:Tomcat]
	Comment 12 • 9 years ago

https://hg.mozilla.org/mozilla-central/rev/bfb0223e3093

	Nazir Ahmed Sabbir [:NaSb]
	Comment 13 • 8 years ago

I've Successfully to reproduce this bug on Nightly 42.0a1 (2015-07-24) (Build ID : 20150724030210) on Linux, 64 Bit.

This Bug is now verified as fixed on Latest Nightly 49.0a1 (2016-05-05); (Build ID: 20160505030327) and

Latest Firefox Developer Edition 48.0a2 (2016-05-05); (Build ID: 20160505004017) 

OS: Ubuntu 16.04 ; Linux 4.4.0-21-generic x86-64
Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0