Closed
Bug 1188138
Opened 9 years ago
Closed 9 years ago
Default buttons have their borders and frames drawn twice on GTK3
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: acomminos, Assigned: acomminos)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
karlt
:
review+
|
Details | Diff | Splinter Review |
If a button is a default button and has a relief, its background and frame will be drawn twice (see moz_gtk_button_paint in gtk3drawing.c, note that case where state->isDefault and relief == GTK_RELIEF_NORMAL). This appears to be unintended, and is not done by upstream GTK's gtk_button_draw.
|
Assignee | |
Comment 1•9 years ago
|
||
This should more accurately follow the upstream GTK implementation, and make default buttons look correct. Thanks!
Attachment #8639558 -
Flags: review?(karlt)
|
||
Updated•9 years ago
|
Attachment #8639558 -
Flags: review?(karlt) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•