Closed
Bug 1188293
Opened 9 years ago
Closed 9 years ago
[hidpi] Dev Edition: back button should use a bright arrow on Windows 10 with dark dev theme
Categories
(Firefox :: Theme, defect, P2)
Tracking
()
RESOLVED
DUPLICATE
of bug 1192397
People
(Reporter: phlsa, Unassigned)
Details
Attachments
(2 files)
devedition-issues.png
When using the dark (default) dev edition theme, the back arrow on Windows 10 is too dark (see attachment). It should be white instead.
In addition, the back button should also fill the entire toolbar height, similar to the location bar.
|
||
Comment 1•9 years ago
|
||
Bug 1187727 already handles the odd sizing. About the dark arrow, I suspect this is because of the DPI settings. Can you test on 100% DPI ?
Summary: Dev Edition: back button is too small and should use a bright arrow on Windows 10 with dark dev theme → Dev Edition: back button should use a bright arrow on Windows 10 with dark dev theme
|
|
||
Updated•9 years ago
|
Flags: needinfo?(philipp)
|
|
||
Updated•9 years ago
|
No longer blocks: windows-10
|
Reporter | |
Comment 2•9 years ago
|
||
(In reply to Tim Nguyen [:ntim] from comment #1)
> Bug 1187727 already handles the odd sizing. About the dark arrow, I suspect
> this is because of the DPI settings. Can you test on 100% DPI ?
You're right, that seems to be the cause. Works at 100%, doesn't work at 200 and 250%.
Flags: needinfo?(philipp)
|
||
Updated•9 years ago
|
Summary: Dev Edition: back button should use a bright arrow on Windows 10 with dark dev theme → [hidpi] Dev Edition: back button should use a bright arrow on Windows 10 with dark dev theme
The same issues occur on Win7 on Release40. + When I move mouse over the dropmarker, it becomes smaller
On Beta41 I only see the issue with "Back" button. On DevEdition42 & Nightly43 I can't see any of these issues. I wonder if they were fixed for Win10 either
|
||
Comment 5•9 years ago
|
||
(In reply to Tim Nguyen [:ntim] (mostly away until 26 August) from comment #4)
> Wasn't this fixed recently ?
Yes, I believe these are Bug 1189410 and Bug 1192397. Philipp, can you confirm that the issues are fixed in current Dev Edition builds?
Flags: needinfo?(bgrinstead) → needinfo?(philipp)
|
|
||
Comment 6•9 years ago
|
||
(In reply to arni2033 from comment #3)
> Created attachment 8648385 [details]
> Dark DevEdition Theme issues on Win7 on HiDPI.png
>
> The same issues occur on Win7 on Release40. + When I move mouse over the
> dropmarker, it becomes smaller
> On Beta41 I only see the issue with "Back" button. On DevEdition42 &
> Nightly43 I can't see any of these issues. I wonder if they were fixed for
> Win10 either
We didn't backport any of the Windows DE issues that were regressed on Beta during the Win10 uplifts since the DE theme isn't officially installable on release. All of the issues in that screenshot should be fixed in Dev Edition though - please let me know if you see them currently in Dev Edition or Nightly builds.
|
|
Reporter | |
Comment 7•9 years ago
|
||
(In reply to Brian Grinstead [:bgrins] from comment #5)
> (In reply to Tim Nguyen [:ntim] (mostly away until 26 August) from comment
> #4)
> > Wasn't this fixed recently ?
>
> Yes, I believe these are Bug 1189410 and Bug 1192397. Philipp, can you
> confirm that the issues are fixed in current Dev Edition builds?
Yep, looks good!
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(philipp)
Resolution: --- → WORKSFORME
|
||
Updated•9 years ago
|
No longer blocks: theme-win10
Resolution: WORKSFORME → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•