Closed
Bug 1188776
Opened 9 years ago
Closed 9 years ago
Remove appId/isInBrowserElement from BroadcastChannel
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: baku)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
bholley
:
review+
|
Details | Diff | Splinter Review |
Bug 1165270 already converted to use origin, so I think we could remove appId/isInBrowserElement from BroadcastChannelParent and BroadcastChannelService.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → amarchesini
|
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8640479 -
Flags: review?(bobbyholley)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8640479 [details] [diff] [review]
bc.patch
Review of attachment 8640479 [details] [diff] [review]:
-----------------------------------------------------------------
::: ipc/glue/BackgroundParentImpl.cpp
@@ +350,1 @@
> const PrincipalInfo& aPrincipalInfo,
Do we still need to be passing aPrincipalInfo here? Or is this an implementation of some more general interface?
Attachment #8640479 -
Flags: review?(bobbyholley) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
we need it for RecvPBroadcastChannelConstructor where we check if the child can load this principal.
The prototype of that method is generated from the IPC constructor.
So yes, we need the principal.
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•9 years ago
|
||
Flags: needinfo?(amarchesini)
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 7•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•