Closed
Bug 1189583
Opened 9 years ago
Closed 9 years ago
[Nexus 4] Add support for the blobfree build
Categories
(Firefox OS Graveyard :: GonkIntegration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: hobinjk, Assigned: hobinjk)
References
Details
Attachments
(3 files, 1 obsolete file)
Like bug 1172912, add the support into gonk-misc/Android.mk and the Nexus 4's device.mk.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8649600 -
Flags: review?(lissyx+mozillians)
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8649601 -
Flags: review?(lissyx+mozillians)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8649602 -
Flags: review?(lissyx+mozillians)
Assignee | ||
Comment 4•9 years ago
|
||
The overview of the changes is that gonk-misc gets support for specifying multiple sources of blobs. device-mako specifies those blobs. gonk-misc also learns how to rename fstab.mako to be recovery.fstab. gonk-misc passes the mkbootimg args into cmdline-fs.txt, which b2g-installer reads and employs. b2g-installer now also deals with the double spaces the mako's system.img cmdline has.
Comment 5•9 years ago
|
||
Nice. That mostly looks all good. I have commented on a few nits/enhancements that might be worthwhile. Sadly, I don't think I'll be able to make it to review quickly before being a couple of days on PTO: need to get a tree to build, need to get a device to test.
Comment 6•9 years ago
|
||
Wait, james, this is a PR against Jelly Bean. I think you might want only KK? At least I'm going to try on a KK build.
Flags: needinfo?(hobinjk)
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #6)
> Wait, james, this is a PR against Jelly Bean. I think you might want only
> KK? At least I'm going to try on a KK build.
This is based on the nexus-4.xml manifest (jb), I will make sure it also works on nexus-4-kk.
Flags: needinfo?(hobinjk)
Assignee | ||
Comment 8•9 years ago
|
||
Attachment #8649600 -
Attachment is obsolete: true
Attachment #8649600 -
Flags: review?(lissyx+mozillians)
Attachment #8650044 -
Flags: review?(lissyx+mozillians)
Updated•9 years ago
|
Assignee: nobody → hobinjk
Comment 9•9 years ago
|
||
Comment on attachment 8649601 [details]
gonk-misc PR
Looks good, I could produce blobfree for Z3c KK and Nexus 4 KK.
Attachment #8649601 -
Flags: review?(lissyx+mozillians) → review+
Comment 10•9 years ago
|
||
Comment on attachment 8649602 [details]
b2g-installer PR
Good but you might want to increase the 5 secs timeout of rebooting to fastboot, it seemed a bit too small.
Attachment #8649602 -
Flags: review?(lissyx+mozillians) → review+
Comment 11•9 years ago
|
||
Comment 12•9 years ago
|
||
Comment 13•9 years ago
|
||
Comment on attachment 8650044 [details]
device-mako PR based on nexus-4-kk
That works great, we just have to change the ro.build.id matching. Something like: [ "KOT49H", "KTU48P" ] should be good.
Flags: needinfo?(hobinjk)
Attachment #8650044 -
Flags: review?(lissyx+mozillians) → review+
Comment 14•9 years ago
|
||
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•