Closed
Bug 1189655
Opened 9 years ago
Closed 9 years ago
define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later
Categories
(Core :: MFBT, defect)
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: m_kato, Assigned: xidorn)
References
Details
Attachments
(1 file)
by http://blogs.msdn.com/b/vcblog/archive/2015/06/02/constexpr-complete-for-vs-2015-rtm-c-11-compiler-c-17-stl.aspx, we will able to define MOZ_HAVE_CXX11_CONSTEXPR even if VS2015.
Reporter | ||
Comment 1•9 years ago
|
||
We cannot compile HTMLTrackElement.cpp using constexpr.
Filed as https://connect.microsoft.com/VisualStudio/feedback/details/1611942/constexpr-causes-internal-compiler-error
Comment 2•9 years ago
|
||
AFAICT, this doesn't block enabling VS2015, so changing dependencies accordingly.
(In reply to Makoto Kato [:m_kato] from comment #1)
> We cannot compile HTMLTrackElement.cpp using constexpr.
>
> Filed as
> https://connect.microsoft.com/VisualStudio/feedback/details/1611942/
> constexpr-causes-internal-compiler-error
Until that bug is fixed, we can either just not define MOZ_HAVE_CXX11_CONSTEXPR, or temporarily change the HTMLTrackElement stuff to avoid constexpr when building with Visual Studio.
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r?waldo
Attachment #8650403 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Brian Smith (:briansmith, :bsmith, use NEEDINFO?) from comment #2)
> Until that bug is fixed, we can either just not define
> MOZ_HAVE_CXX11_CONSTEXPR, or temporarily change the HTMLTrackElement stuff
> to avoid constexpr when building with Visual Studio.
We need to do neither one. That internal error is easy to workaround.
Comment 5•9 years ago
|
||
Comment on attachment 8650403 [details]
MozReview Request: Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r?waldo
https://reviewboard.mozilla.org/r/16623/#review14935
Ship It!
Attachment #8650403 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 6•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/a5420073ea387c4c74814beca323af365b793e4c
changeset: a5420073ea387c4c74814beca323af365b793e4c
user: Xidorn Quan <quanxunzhen@gmail.com>
date: Fri Aug 21 09:17:18 2015 +1000
description:
Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r=Waldo
Comment 7•9 years ago
|
||
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•