Closed Bug 1189655 Opened 9 years ago Closed 9 years ago

define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later

Categories

(Core :: MFBT, defect)

Unspecified
Windows
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- affected
firefox43 --- fixed

People

(Reporter: m_kato, Assigned: xidorn)

References

Details

Attachments

(1 file)

Blocks: VC14
AFAICT, this doesn't block enabling VS2015, so changing dependencies accordingly. (In reply to Makoto Kato [:m_kato] from comment #1) > We cannot compile HTMLTrackElement.cpp using constexpr. > > Filed as > https://connect.microsoft.com/VisualStudio/feedback/details/1611942/ > constexpr-causes-internal-compiler-error Until that bug is fixed, we can either just not define MOZ_HAVE_CXX11_CONSTEXPR, or temporarily change the HTMLTrackElement stuff to avoid constexpr when building with Visual Studio.
No longer blocks: VC14
Depends on: VC14
Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r?waldo
Attachment #8650403 - Flags: review?(jwalden+bmo)
(In reply to Brian Smith (:briansmith, :bsmith, use NEEDINFO?) from comment #2) > Until that bug is fixed, we can either just not define > MOZ_HAVE_CXX11_CONSTEXPR, or temporarily change the HTMLTrackElement stuff > to avoid constexpr when building with Visual Studio. We need to do neither one. That internal error is easy to workaround.
Comment on attachment 8650403 [details] MozReview Request: Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r?waldo https://reviewboard.mozilla.org/r/16623/#review14935 Ship It!
Attachment #8650403 - Flags: review?(jwalden+bmo) → review+
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/a5420073ea387c4c74814beca323af365b793e4c changeset: a5420073ea387c4c74814beca323af365b793e4c user: Xidorn Quan <quanxunzhen@gmail.com> date: Fri Aug 21 09:17:18 2015 +1000 description: Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r=Waldo
Assignee: nobody → quanxunzhen
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: