Closed
Bug 1189671
Opened 9 years ago
Closed 9 years ago
"Harness status: ERROR" when running "getregistrations.sub.html" test
Categories
(Testing :: web-platform-tests, defect)
Testing
web-platform-tests
Tracking
(firefox42 affected, firefox44 fixed)
RESOLVED
FIXED
mozilla44
People
(Reporter: noemi, Assigned: nsm)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
Details |
Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/getregistrations.sub.html|
Actual Result:
Harness status: Error
ReferenceError: sequential_promise_test is not defined
Found 0 tests
Traces: https://pastebin.mozilla.org/8838608
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1189671 - Fix getregistrations test. r?jgraham
Moves the test to .https so it actually works.
Switches to using promise_test like the current blink test since sequential promise is not implemented and not needed.
compares registrations by scope since getRegistrations() produces new objects every time.
Attachment #8651311 -
Flags: review?(james)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → nsm.nikhil
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8651311 [details]
MozReview Request: Bug 1189671 - Fix getregistrations test. r?jgraham
https://reviewboard.mozilla.org/r/16899/#review15201
::: testing/web-platform/mozilla/tests/service-workers/service-worker/getregistrations.https.html:96
(Diff revision 1)
> // Top-level window's origin is http://{{domains[www]}}:{{ports[http][0]}}
Since you removed the .sub. remove these comments here and elsewhere.
::: testing/web-platform/mozilla/tests/service-workers/service-worker/getregistrations.https.html:100
(Diff revision 1)
> - '/service-worker/resources/frame-for-getregistrations.sub.html';
> + '/_mozilla/service-workers/service-worker/resources/frame-for-getregistrations.html';
You can't put _mozilla in paths if we want to upstream these tests.
I guess the right option is to add some substitution for the path prefix, which might require an upstream change in wptserve.
If that's the route we decide to go I'm OK with landing this change temporarily as long as you file a followup issue to remove the _mozilla once I land the upstream change (or, for bonus points, make the upstream change yourself :)
Attachment #8651311 -
Flags: review?(james)
Assignee | ||
Comment 3•9 years ago
|
||
I changed the test to calculate the URL based on the current URL to obviate the second issue.
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
Assignee | ||
Comment 9•9 years ago
|
||
Assignee | ||
Comment 10•9 years ago
|
||
Assignee | ||
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d09c2c24624fe52c46b9059aa93a446360ee4d62
Bug 1189671 - Fix getregistrations test. r=jgraham
Comment 12•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Reporter | ||
Comment 13•9 years ago
|
||
Hi,
|./mach web-platform-tests _mozilla/service-workers/service-worker/getregistrations.https.html| just checked on m-c (001942e4617b revision) and the test successfully runs. Thanks for fixing it!
Summary
Harness status: OK
Found 6 tests
6 Pass
Details
Result Test Name
Pass Purge the existing registrations.
Pass getRegistrations
Pass Register then getRegistrations
Pass Register multiple times then getRegistrations
Pass Register then Unregister then getRegistrations
Pass getRegistrations promise resolves only with same origin registrations.
You need to log in
before you can comment on or make changes to this bug.
Description
•