Closed
Bug 1189704
Opened 9 years ago
Closed 9 years ago
Identity block, separator and URL move when URL is edited
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox41 | --- | unaffected |
firefox42 | + | verified |
firefox43 | + | verified |
People
(Reporter: Virtual, Assigned: Paolo)
References
Details
(Keywords: nightly-community, regression, Whiteboard: [fxprivacy])
Attachments
(5 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
MozReview Request: Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins
(deleted),
text/x-review-board-request
|
bgrins
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details |
Probably caused by Bug #1185362
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 3•9 years ago
|
||
I don;t know it was intended and it's relevant, but identity block isn't in center between separator and the go back button.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•9 years ago
|
Summary: identity block, separator and URL moves when it's activated → identity block, separator and URL moves when URL bar it's activated
Assignee | ||
Comment 6•9 years ago
|
||
I don't see this on a recent Nightly on Windows 7. Are you using a custom theme or maybe a lightweight theme?
Updated•9 years ago
|
Flags: firefox-backlog?
Whiteboard: [fxprivacy]
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 7•9 years ago
|
||
I'm just using my lightweight theme (aka old Personas) named "Virtualfox", no custom full theme.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 8•9 years ago
|
||
I forgot to add that you need to edit address, so for example delete "/" in the end of the URL to make it happen.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•9 years ago
|
Summary: identity block, separator and URL moves when URL bar it's activated → identity block, separator and URL moves when URL bar it's edited
Comment 9•9 years ago
|
||
(In reply to Virtual_ManPL [:Virtual] from comment #0)
> Probably caused by Bug #1185362
Let's actually figure this out rather than guessing. Bug 1185362 isn't the only recent change in this area.
No longer blocks: 1185362
Keywords: regressionwindow-wanted
Updated•9 years ago
|
Summary: identity block, separator and URL moves when URL bar it's edited → Identity block, separator and URL move when URL is edited
Updated•9 years ago
|
Flags: firefox-backlog? → firefox-backlog+
Priority: -- → P2
Comment 10•9 years ago
|
||
[Tracking Requested - why for this release]: small but pretty obvious regression in primary UI
tracking-firefox42:
--- → ?
Updated•9 years ago
|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 43.1 - Aug 24
Flags: qe-verify?
Priority: P2 → P1
Assignee | ||
Comment 11•9 years ago
|
||
Looks like when reviewing bug 1185362 I missed that the shield animation margin had to be adjusted as the 2px margin was added between the lock and the shield icons.
I've also fixed the animation direction for RTL interfaces while here.
Assignee | ||
Comment 12•9 years ago
|
||
Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins
Attachment #8648707 -
Flags: review?(bgrinstead)
Assignee | ||
Updated•9 years ago
|
Flags: qe-verify? → qe-verify+
Keywords: regressionwindow-wanted
Comment 13•9 years ago
|
||
Comment on attachment 8648707 [details]
MozReview Request: Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins
https://reviewboard.mozilla.org/r/16269/#review14531
Looks good, thanks. Please update the commit message to say what the fix is doing rather than restating the problem
Attachment #8648707 -
Flags: review?(bgrinstead) → review+
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•9 years ago
|
status-firefox43:
--- → affected
tracking-firefox43:
--- → ?
Comment 17•9 years ago
|
||
Updated•9 years ago
|
QA Contact: mwobensmith
Comment 18•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Assignee | ||
Comment 19•9 years ago
|
||
Note that the right changeset for uplift is just this one:
https://hg.mozilla.org/integration/fx-team/rev/b220196bb58d
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 20•9 years ago
|
||
Requesting an uplift to 42, as this versions is also affected.
Flags: needinfo?(paolo.mozmail)
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•9 years ago
|
Flags: needinfo?(bgrinstead)
Assignee | ||
Comment 21•9 years ago
|
||
Comment on attachment 8648707 [details]
MozReview Request: Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins
Approval Request Comment
[Feature/regressing bug #]: Identity Block Redesign
[User impact if declined]: A noticeable two-pixel misalignment when the user starts typing
[Describe test coverage new/current, TreeHerder]: Landed on mozilla-central, awaiting QA. The entire Identity Block area is pending detailed QA on the Developer Edition channel anyways.
[Risks and why]: Alignment regressions for cases we didn't think about would be limited to the specific UI area
[String/UUID change made/needed]: None
Flags: needinfo?(paolo.mozmail)
Flags: needinfo?(bgrinstead)
Attachment #8648707 -
Flags: approval-mozilla-aurora?
Comment 22•9 years ago
|
||
Comment on attachment 8648707 [details]
MozReview Request: Bug 1189704 - Identity block, separator and URL move when URL is edited. r=bgrins
Visual recent regression, taking it.
Attachment #8648707 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 23•9 years ago
|
||
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Keywords: nightly-community
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
QA Contact: mwobensmith → Virtual
You need to log in
before you can comment on or make changes to this bug.
Description
•