Closed
Bug 1189750
Opened 9 years ago
Closed 9 years ago
Remove unused JM-related PCCounts counters.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: nbp, Assigned: nbp)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
PCCounts has a lot of counters which were related to the information collected by JM. Apart from the the BASE_INTERP counter, no other counter are updated.
This counter is only used by the PCCounts friend API, but it might be useful to reuse this code for implementing the Code Coverage recent project, as highlighted in Bug 1176880 prototype.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8641688 -
Flags: review?(bhackett1024)
Updated•9 years ago
|
Attachment #8641688 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8641688 [details] [diff] [review]
Remove unused JM-related PCCounts counters.
Review of attachment 8641688 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsopcode.cpp
@@ +173,5 @@
> bool printed = false;
> + double val = script->getPCCounts(pc).numExec();
> + if (val) {
> + if (printed)
> + Sprint(sp, ", ");
While re-reading my patch, I notice that this printed flag is useless now. I'll remove it before landing.
Assignee | ||
Comment 4•9 years ago
|
||
As the counter is now part of the PCCounts structure, we should no longer
make any copy of the counter, otherwise the numExec() function will return a
reference to a temporary returned copy, and not to the original PCCounts
content.
Attachment #8642459 -
Flags: review?(bhackett1024)
Updated•9 years ago
|
Attachment #8642459 -
Flags: review?(bhackett1024) → review+
Comment 5•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Comment 7•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•