Closed
Bug 1190082
Opened 9 years ago
Closed 9 years ago
Rename media-playback and the related stuff to audio-playback
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Given that we only dispatch this for audio, media-playback sounds
like a misnomer.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8642048 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8642048 [details] [diff] [review]
Rename media-playback and the related stuff to audio-playback
Olli, can you please help review this? This is a simple renaming patch!
Attachment #8642048 -
Flags: review?(amarchesini) → review?(bugs)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8642048 [details] [diff] [review]
Rename media-playback and the related stuff to audio-playback
Not about this bug, but DOMAudioPlaybackStarted shouldn't be cancelable, nor
DOMAudioPlaybackStopped
Shouldn't you rename mediaPlaybackStarted and mediaPlaybackStopped in browser.xml too?
rs+.
Attachment #8642048 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #3)
> Not about this bug, but DOMAudioPlaybackStarted shouldn't be cancelable, nor
> DOMAudioPlaybackStopped
Good catch! Filed as bug 1191123.
> Shouldn't you rename mediaPlaybackStarted and mediaPlaybackStopped in
> browser.xml too?
Will do.
|
||
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•