Let's use this bug to polish the tab audio indicator I built in bug 1018504, since I don't want to block landing those patches on my available free time to work on this :) Here's a current APK: http://people.mozilla.org/~mleibovic/tmp/tab-audio.apk Some outstanding questions: * Position of tab audio indicator * Whether or not to allow muting/unmuting (if so, need larger tap area and muted icon)

I feel like this is a better position for position in tabs tray on Mobile (vertical). Still to add: tablets.

inline, padded 6 dp from the title :)

...and tablets!

in the tabs tray, the icon is icon grey (#AFB1B3) with 6 dp padding before the Page title.

I like this new tablet design because it will help address the issue of fat-fingering the mute button and accidentally closing the tab. I'll start working on this! I also commented in bug 1191159 about adding a "muted" icon.

Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella

Bug 1190301 - Enable tab audio indicator by default. r=mcomella

Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mcomella

(In reply to :Margaret Leibovic from comment #7) > Created attachment 8651892 [details] > MozReview Request: Bug 1190301 - Remove mute button functionality from tab > audio indicator. r=mcomella > > Bug 1190301 - Remove mute button functionality from tab audio indicator. > r=mcomella I did this based on antlam's comments in bug 1191159. I didn't fully flesh out this feature when I landed it, so I'm removing the half-baked code.

Comment on attachment 8651892 [details] MozReview Request: Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella

Comment on attachment 8651893 [details] MozReview Request: Bug 1190301 - Enable tab audio indicator by default. r=mcomella Bug 1190301 - Enable tab audio indicator by default. r=mcomella

Comment on attachment 8651894 [details] MozReview Request: Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mhaigh Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mhaigh

Comment on attachment 8651892 [details] MozReview Request: Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella

Comment on attachment 8651893 [details] MozReview Request: Bug 1190301 - Enable tab audio indicator by default. r=mcomella Bug 1190301 - Enable tab audio indicator by default. r=mcomella

mcomella told me that mhaigh was planning on removing this layout, so I don't want to stress too much about making it look perfect, but this is what it looks like with this patch.

Comment on attachment 8651894 [details] MozReview Request: Bug 1190301 - Use compound drawables instead of ImageButton views for tab audio indicator. r=mhaigh https://reviewboard.mozilla.org/r/17009/#review16025

Comment on attachment 8651892 [details] MozReview Request: Bug 1190301 - Remove mute button functionality from tab audio indicator. r=mcomella https://reviewboard.mozilla.org/r/17005/#review16027

Comment on attachment 8651893 [details] MozReview Request: Bug 1190301 - Enable tab audio indicator by default. r=mcomella https://reviewboard.mozilla.org/r/17007/#review16029

Taking while Margaret is PTO.

For this to land, it looks like bug 1198084 needs to land – which is an a11y content description update when playing audio – and to rebase the changes to the tabs panel onto Martyn's latest tabs tray rewrites.

Correction: the implementation of bug 1198084 would change depending on if this bug landed or not, so let's land this first.

Looks like the new phone tabs tray just worked because it's the same implementation as tablet.

https://hg.mozilla.org/integration/fx-team/rev/746f8a88c401 https://hg.mozilla.org/integration/fx-team/rev/8056ee3e5b83 https://hg.mozilla.org/integration/fx-team/rev/fb806fe87320

Oh, two of the commits in comment 26 have the wrong reviewer – it should be mhaigh, not mcomella.

https://hg.mozilla.org/mozilla-central/rev/746f8a88c401 https://hg.mozilla.org/mozilla-central/rev/8056ee3e5b83 https://hg.mozilla.org/mozilla-central/rev/fb806fe87320

Moving this back to 43, as per bug 1018504 comment 32 and subsequent comments.

Release Note Request (optional, but appreciated) [Why is this notable]: We can see which tabs are playing audio now! [Suggested wording]: Display which tabs are playing audio in tab list [Links (documentation, blog post, etc)]: N/A

I think this is close enough to the note for bug 1018504 that I can just combine them into one.

Verified as fixed in Firefox 43 Beta 7; Devices: Asus ZenPad 8 (Android 5.0.2); Nexus 5 (Android 6.0); Samsung Galaxy R (Android 2.3.4).