Closed
Bug 1190457
Opened 9 years ago
Closed 9 years ago
Convert AutoPropertyDescriptorVector to normal Rooted usage
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
AutoVector exposes [Mutable]Handle through operator[]. Given that [Mutable]TraceableVectorOperations is only used via Rooted primitives, I think it is safe to add such there as well. Once we do that (and fix up the AutoShapeVector usage), converting from AutoPropertyDescriptorVector to Rooted<TraceableVector<PropertyDescriptor>> is as trivial as changing the names.
Attachment #8642498 -
Flags: review?(jcoppeard)
Comment 1•9 years ago
|
||
Comment on attachment 8642498 [details] [diff] [review]
auto_propdesc_vec-v1.diff
Review of attachment 8642498 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good!
::: js/public/TraceableVector.h
@@ +96,5 @@
> T& back() { return vec().back(); }
>
> + JS::MutableHandle<T> operator[](size_t aIndex) {
> + return JS::MutableHandle<T>::fromMarkedLocation(&vec().operator[](aIndex));
> + }
You may need to add the const version here as well, as per bug 1189722.
Attachment #8642498 -
Flags: review?(jcoppeard) → review+
Comment 3•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•