Closed
Bug 1190478
Opened 9 years ago
Closed 9 years ago
Hide PushEvent.data until we ship message encryption.
Categories
(Core :: DOM: Notifications, defect)
Core
DOM: Notifications
Tracking
()
RESOLVED
FIXED
mozilla42
| Tracking | Status | |
|---|---|---|
| firefox42 | --- | fixed |
People
(Reporter: nsm, Assigned: nsm)
References
Details
Attachments
(1 file)
Martin, This is a less invasive change than hiding the PushMessageData interface, but if you prefer the latter, let me know.
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1190478 - Hide PushEvent.data until we ship message encryption. r?mt,jst
Attachment #8642528 -
Flags: review?(martin.thomson)
Attachment #8642528 -
Flags: review?(jst)
|
||
Updated•9 years ago
|
Attachment #8642528 -
Flags: review?(martin.thomson)
|
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8642528 [details]
MozReview Request: Bug 1190478 - Hide PushEvent.data until we ship message encryption. r?mt,jst
https://reviewboard.mozilla.org/r/14725/#review13315
::: dom/workers/ServiceWorkerEvents.h:193
(Diff revision 1)
> + // nsRefPtr<PushMessageData> mData;
I don't think that I would have removed this, or the cycle collection stuff. Removing the attributes from the WebIDL and then making the tests pass should be enough.
|
||
Comment 3•9 years ago
|
||
|
|
||
Updated•9 years ago
|
Attachment #8642528 -
Flags: review?(jst) → review+
|
|
||
Updated•9 years ago
|
Attachment #8642528 -
Flags: checkin+
|
|
||
Updated•9 years ago
|
Attachment #8642528 -
Flags: checkin+ → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/14003c5e401ddc28b3d4c5e9da785b35facc80b0
changeset: 14003c5e401ddc28b3d4c5e9da785b35facc80b0
user: Nikhil Marathe <nsm.nikhil@gmail.com>
date: Mon Aug 03 11:04:41 2015 -0700
description:
Bug 1190478 - Hide PushEvent.data until we ship message encryption. r=mt,jst
|
||
Comment 5•9 years ago
|
||
Assignee: nobody → nsm.nikhil
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•