Closed
Bug 1191173
Opened 9 years ago
Closed 9 years ago
Mirror MediaDecoder::mSameOriginMedia in MDSM
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(1 file)
So we can remove MediaDecoder::IsSameOriginMedia which is called by MDSM on a non-main thread.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1191173 - Mirror MediaDecoder::mSameOriginMedia in MDSM.
Attachment #8644095 -
Flags: review?(jyavenard)
Updated•9 years ago
|
Attachment #8644095 -
Flags: review?(jyavenard) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8644095 [details]
MozReview Request: Bug 1191173 - Mirror MediaDecoder::mSameOriginMedia in MDSM.
https://reviewboard.mozilla.org/r/15227/#review13655
::: dom/media/MediaDecoder.cpp:416
(Diff revision 1)
> + "MediaDecoder::mSameOriginMedia (Canonical)")
it seems that the usual mozilla is to always add a trailing , even on the last member, or have it at the front. (I like the later better)
How often does mSameOriginMedia changes ? Should it be set once and for all in the decoder ? If that's the case and it's known when creating the state machine it could be passed as parameter instead.
Assignee | ||
Comment 4•9 years ago
|
||
https://reviewboard.mozilla.org/r/15227/#review13655
> it seems that the usual mozilla is to always add a trailing , even on the last member, or have it at the front. (I like the later better)
Yeah, I also like the later better. But for now I just follow the existing style of MediaDecoder. I will file a new bug to fix the style.
MediaDecoder::UpdateSameOriginStatus() is called by HTMLMediaElement::NotifyDecoderPrincipalChanged() which is called when new data with different principals are downloaded (see MediaCacheStream::NotifyDataReceived). So it is not immutable.
Comment 7•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in
before you can comment on or make changes to this bug.
Description
•