Closed Bug 1191315 Opened 9 years ago Closed 6 years ago

Update |_lastSessionCheckpointTime| when sending daily pings

Categories

(Toolkit :: Telemetry, defect, P4)

Product:
Toolkit
Component:
Telemetry
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED WORKSFORME
Tracking Flags:
Tracking Status
firefox40 --- wontfix
firefox41 --- affected
firefox42 --- affected

People

(Reporter: Dexter, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [unifiedTelemetry] [measurement:client]) 

When generating daily pings, we also save the payload as an "aborted-session" ping, to prevent gathering the data twice.

We're not updating |_lastSessionCheckpointTime| [1] though, so we may be writing a new aborted-session ping a few seconds after a daily ping (and the relative aborted-session ping) was generated

[1] - http://hg.mozilla.org/mozilla-central/annotate/5e8e09201617/toolkit/components/telemetry/TelemetrySession.jsm#l549
Blocks: 1122482
status-firefox41: --- → affected
Whiteboard: [unifiedTelemetry]
Blocks: 1120356
No longer blocks: 1122482
Whiteboard: [unifiedTelemetry] → [unifiedTelemetry] [uplift4]
Blocks: 1122482
No longer blocks: 1120356
Whiteboard: [unifiedTelemetry] [uplift4] → [unifiedTelemetry] [uplift5]
Blocks: 1201022
No longer blocks: 1122482
Points: --- → 1
Priority: -- → P3
Whiteboard: [unifiedTelemetry] [uplift5] → [unifiedTelemetry] [measurement:client]
Priority: P3 → P4
This is about making Telemetry disk access a bit more efficient in edge cases.
We have not had this come up in performance issues, so i assume this is ok.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.