Closed
Bug 1191494
Opened 9 years ago
Closed 9 years ago
[meta] Implement minimal UI prototype for Contextual Identity Project
Categories
(Firefox :: Security, defect)
Firefox
Security
Tracking
()
RESOLVED
FIXED
People
(Reporter: englehardt, Assigned: englehardt)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
The Contextual Identity project (Bug 1191418) needs a minimal UI as a proof of concept / for use in user tests. The minimal set of UI elements are defined as:
* Bug 1191442 - A File menu item
* Bug 1191451 - Tab decoration indicating userContextId
* Bug 1191455 - URL Bar decoration indicating userContextId
Future iterations will add:
* Containers Hamburger menu icon
* Landing pages for containers new tab
* The ability to create new containers
* about:containers page for container management
* Right click / keyboard shortcut to "Open Link in Container"
* Cookie manager UI updates
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Hey Bram. Here is my current implementation of the V1 UI. The screenshot messes up the selected menu items, but everything else is captured correctly. Let me know what you think!
Attachment #8650604 -
Flags: feedback?(bram)
Comment 2•9 years ago
|
||
I had a discussion with Steven earlier today. Two things to note:
1. Calling the menu item “New Containers Tab” is fine for now, but for future versions, consider calling it “Containers” in the interest of making the menu more versatile.
By calling the parent item “Containers”, we can have child items that say “Containers Preferences…” and “Add New Container…” – both future features. But these items don’t really have a place in the menu if we call its parents “New Containers Tab”.
2. It may be possible to move the tab highlight colour down so it starts below the tab’s top border. At the moment, the highlight colour starts above the tab area and ends on tab border. See attachment for difference.
Updated•9 years ago
|
Attachment #8650604 -
Flags: feedback?(bram) → feedback+
Would it make sense to add a context menu (right click) to the new tab button? A menu similar/(identical?) to the one in bug 1191442.
It would certainly make the feature more accessible, especially since the menu bar is hidden on Windows.
Comment 4•9 years ago
|
||
(In reply to Johan C from comment #3)
> Would it make sense to add a context menu (right click) to the new tab
> button? A menu similar/(identical?) to the one in bug 1191442.
> It would certainly make the feature more accessible, especially since the
> menu bar is hidden on Windows.
Thanks Johan for your comment! We can look into that. For now, we are just working on the minimal UI to get a working feature and have a number of enhancements we can do on top of that.
On our list of followups we have "Open link in New Container" when you right click and an item to add it to the hamburger menu. Not sure if it belongs in Context Menu since Context Menu doesn't have any tab opening options today.
Assignee | ||
Comment 5•9 years ago
|
||
Try push of final r+'ed patches for the three dependent bugs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ba18a86e004
Comment 6•9 years ago
|
||
All dependencies have landed so the minimal UI is now done! Closing this out. Thank you Steve and Bram!
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•