nsSpeechTask has to use nsIAudioChannelAgent to notify audio indicator. Env Windows 8.1 (Web Speech Synthesis backend is only implemented on Windows) Step 1. media.webspeech.synth.enabled=true on about:config and restart 2. Browser http://html5-examples.craic.com/google_chrome_text_to_speech.html 3. Click [Speak] in Demo 1: Result no audio indicator on current tab Expected Result Show audio indicator on current tab

nsSpeechTask should have nsIAudioChannelAgentCallback interface for audio indicator. So add dependency bug

Comment on attachment 8652174 [details] [diff] [review] Part 1. Add onVolumeChanged method to nsISpeechTaskCallback add onVolumeChanged method to change volume after starting speak.

Comment on attachment 8652175 [details] [diff] [review] Part 2. Call onVolumeChanged when changing volume When WindowVolumeChanged is called, we should change volume on indirect service, too.

Comment on attachment 8652174 [details] [diff] [review] Part 1. Add onVolumeChanged method to nsISpeechTaskCallback Review of attachment 8652174 [details] [diff] [review]: ----------------------------------------------------------------- This is great! How about a test? ::: dom/media/webspeech/synth/nsISpeechService.idl @@ +30,5 @@ > */ > void onCancel(); > + > + /** > + * The user or applicatioln has changed the volume of this speech. typo, application.

Comment on attachment 8652175 [details] [diff] [review] Part 2. Call onVolumeChanged when changing volume Review of attachment 8652175 [details] [diff] [review]: ----------------------------------------------------------------- Not sure why this is a separate patch, but this is good too.

Comment on attachment 8652708 [details] [diff] [review] Part 3. Call NotifyStartedPlaying to show audio indicator I forget additional fix. I think that bug 1191814's fix is still incorrect. To show audio indicator, we have to call NotifyStartedPlaying(). Also, WindowVolumeChanged() has a bug (see bug 1197673), so to work correctly, we have to apply it too.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf29589b47c8 https://hg.mozilla.org/integration/mozilla-inbound/rev/c55b38a5ee09 https://hg.mozilla.org/integration/mozilla-inbound/rev/c92a7a24d757

https://hg.mozilla.org/mozilla-central/rev/cf29589b47c8 https://hg.mozilla.org/mozilla-central/rev/c55b38a5ee09 https://hg.mozilla.org/mozilla-central/rev/c92a7a24d757