Dietrich Ayala (:dietrich) Reporter
	Description • 9 years ago

User-Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Title says it all. Terribly annoying after the 20th time in a day.

	Dietrich Ayala (:dietrich) Reporter
	Comment 1 • 9 years ago

Clarified STR:

1. do a rocketbar search (keyboard opens)
2. go away to an app or homescreen, whatever
3. do another rocketbar search (keyboard opens, see prior search results)
4. clear prior search by touching the [x]

Expected: search results go away, keyboard stays up

Actual: search results go away, keyboard goes away

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 2 • 9 years ago

The right question to ask is, why do users has to clean up the prior search result?
Was the search result committed at step 2? If so it should get cleaned up right?

If it wasn't, I agree we should move the focus right back to the input to prevent keyboard from disappearing.

	Tim Guan-tin Chien [:timdream] (please needinfo)
	Comment 3 • 9 years ago

Was the prior search result selected at step 3? If so start typing should replace the text instantly right?

	Dietrich Ayala (:dietrich) Reporter
	Comment 4 • 9 years ago

Maybe caused by bug 1182189. Dale said it started after or around the 27th.

	Dietrich Ayala (:dietrich) Reporter
	Comment 5 • 9 years ago

(In reply to Tim Guan-tin Chien [:timdream] (slow response; please ni? to queue) from comment #3)
> Was the prior search result selected at step 3? If so start typing should
> replace the text instantly right?

I don't quite understand - the prior search text is already in the field. Can you clarify what you mean?

Regardless, I tried both cases:

* select search result

* move away without selecting search result (home button, notification selection, etc)

In both cases, typing in the field appends to the prior search text.

	Luke Chang [:lchang] (inactive)
	Comment 6 • 9 years ago

I think this bug isn't related to bug 1182189.

After bisecting, I found the first bad commit is becb0ba234f6d18b0ffe070b9e525a907081e9ee, which is Bug 1054239. However, I haven't figured out yet why that bug causes this issue.

	Dietrich Ayala (:dietrich) Reporter
	Comment 7 • 9 years ago

Thanks for checking Luke! Ni? Wilson Page, who fixed bug 1054239.

	Wilson Page [:wilsonpage] Assignee
	Comment 9 • 9 years ago

I'm not sure how this regressed, perhaps it was a stroke of luck that it was working previously.

I investigated and it seems that the 'X' button is stealing focus from the <input> so the keyboard closes. This patch purposely refocused the <input> after the 'X' button has been clicked. I've also added a unit-test to prove behaviour.

	Pi Wei Cheng [:piwei] (inactive)
	Comment 10 • 9 years ago

STR:
1) Tap on Rocketbar on Homescreen, type in a search term, and press enter on keyboard -> search results displayed on browser
2) Tap Home button
3) Tap on Rocketbar again
4) Press X on search field to clear previous search term on rocketbar

Expected: Keyboard remains

Actual: Keyboard dismisses 

Issue reproduces on Aries and Flame 2.5.

Device: Aries 2.5
BuildID: 20150814042814
Gaia: 39b121515ab8a8c3ea07f26d3ba1dd792e90217c
Gecko: 4e883591bb5dff021c108d3e30198a99547eed1e
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (2.5) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Device: Flame 2.5
BuildID: 20150814030213
Gaia: 39b121515ab8a8c3ea07f26d3ba1dd792e90217c
Gecko: 4e883591bb5dff021c108d3e30198a99547eed1e
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (2.5) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

----

Issue does NOT reproduce on Flame 2.2. Keyboard remains after doing step 4.

Device: Flame 2.2
BuildID: 20150814032503
Gaia: 102f1299e9eafe3760e1deb44d556b5c4f36b5af
Gecko: 9295034c0ee3
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

	Alberto Pastor [:albertopq]
	Comment 11 • 9 years ago

Comment on attachment 8645935 [details]
[gaia] wilsonpage:1191671 > mozilla-b2g:master

Looks good to me. Thanks!

	Wilson Page [:wilsonpage] Assignee
	Comment 12 • 9 years ago

Comment on attachment 8645935 [details]
[gaia] wilsonpage:1191671 > mozilla-b2g:master

https://github.com/mozilla-b2g/gaia/commit/fa32b801f6d854e846ea8294dc37840450d36c1e

	Shally Li（leave from Mozilla）
	Comment 14 • 9 years ago

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 10.

Actual results: Clearing previous search in rocketbar will not dismiss keyboard.
See attachment: verified_Flame_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150910150202
Gaia Revision          6280500a6cb8d1b178cdd163450e36d22846fbed
Gaia Date              2015-09-10 11:38:24
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/7671701d15cadd2b343fc27685231e0689bb71df
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150910.182915
Firmware Date          Thu Sep 10 18:29:25 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150911000328
Gaia Revision          6280500a6cb8d1b178cdd163450e36d22846fbed
Gaia Date              2015-09-10 11:38:24
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/c0abc2a6e11f52761366e029eb1bae4c9864a8a3
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150910.232411
Firmware Date          Thu Sep 10 23:24:19 UTC 2015
Bootloader             s1