Closed Bug 1191868 Opened 9 years ago Closed 9 years ago

Convert simulator to be based on Mulet

Categories

(Firefox OS Graveyard :: Simulator, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
FxOS-S9 (16Oct)
Tracking Status
firefox44 --- fixed

People

(Reporter: jryans, Assigned: ochameau)

References

Details

Attachments

(2 files, 1 obsolete file)

Mulet is getting good test coverage in automation, and there is interest in having less environments to worry about, like removing b2g-desktop builds. We should convert the Simulator add-on so that it's based on Mulet instead of b2g-desktop, so we can remove a dependency on b2g-desktop. We would still offer the same feature set and UI as the existing simulator does today, it's just built around a different base internally.
Is there any progress on this?
No, we just managed to get simulator working after addon signing story broke all addons... We will now look into this mulet. I'll.
Assignee: nobody → poirot.alex
Depends on: 1207653
I haven't found any reasonable way to override the default chrome URI loaded from Mulet. There is the browser glue component of firefox that opens a browser.xul window no matter what. And I don't want to introduce some mulet specifics in this firefox code. There might be a way to hack this by monkey patching stuff during build process of the addon, but I found that WebIDE easier to maintain. The good side of this technique is that it can give control to WebIDE to open the browser UI of mulet or not. The bad side of it is that it will make the addon behave very badly on FF44- or actually, we should ensure that this addon is not compatible with FF44-! You can test this patch with this try build: https://queue.taskcluster.net/v1/task/M8_NIQqCROKYAziPa7kKtg/runs/0/artifacts/public/build/fx-os-simulator-2.5.20150923160039-linux64.xpi
Comment on attachment 8664977 [details] [diff] [review] tweak webide to support mulet sim - v1 What do you think about the whole mulet story here? You can look at the related build script attachment 8664939 [details] [diff] [review].
Attachment #8664977 - Flags: feedback?(jryans)
Attached patch remove b2g-desktop simulator support (obsolete) (deleted) — Splinter Review
Then, if we are happy with simulator builds, we can cleanup stuff by removing unecessary addon files, as well as removing b2g desktop support. I throw the patch here, but that sounds more like a followup.
Comment on attachment 8664977 [details] [diff] [review] tweak webide to support mulet sim - v1 This seems fine to me. Like you mentioned, we may want to restrict the Mulet based add-on to versions of WebIDE that know about this extra param.
Attachment #8664977 - Flags: feedback?(jryans) → feedback+
(In reply to Alexandre Poirot [:ochameau] from comment #6) > Created attachment 8665384 [details] [diff] [review] > remove b2g-desktop simulator support > > Then, if we are happy with simulator builds, > we can cleanup stuff by removing unecessary addon files, > as well as removing b2g desktop support. > > I throw the patch here, but that sounds more like a followup. Yes, let's move this to a follow up.
Attached patch Bump addon fx minVersion (deleted) — Splinter Review
Comment on attachment 8664977 [details] [diff] [review] tweak webide to support mulet sim - v1 Review of attachment 8664977 [details] [diff] [review]: ----------------------------------------------------------------- We are now able to build simulator addons for linux from try. I may replace the try build (to prevent building simulators for all try builds) by building it on mozilla-central revisions so that we get nightlies. I think we can now proceed with this patch. I just launched a try run to get a simulator: https://treeherder.allizom.org/#/jobs?repo=try&revision=db2f08371226 The build should be available on this page once the build is done: https://tools.taskcluster.net/task-graph-inspector/#MFBnNqrETGa_q3-CVN8XWg/H3mwCNx3RMSYcG_hkMawUg
Attachment #8664977 - Flags: review?(jryans)
Attachment #8666917 - Flags: review?(jryans)
Blocks: 1210382
Attachment #8664977 - Flags: review?(jryans) → review+
Attachment #8666917 - Flags: review?(jryans) → review+
https://hg.mozilla.org/integration/fx-team/rev/226ab102869c5fddbd99092c22ffb08fdf93935d Bug 1191868 - Bump fxos simulator addon compatiblity to current nightly. r=jryans https://hg.mozilla.org/integration/fx-team/rev/350c0e6a2d5809fadd5a0349b4864c5eb2333a31 Bug 1191868 - Tweak WebIDE to support Simulator based on Mulet. r=jryans
Attachment #8665384 - Attachment is obsolete: true
Depends on: 1211453
Blocks: 1208568
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: