Closed
Bug 1192434
Opened 9 years ago
Closed 9 years ago
Adjust the vertical padding of the identity box across platforms
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: Paolo, Assigned: Paolo)
References
Details
(Keywords: regression)
Attachments
(1 file)
The inner vertical padding of the identity box is too small, causing the height of the address bar on Windows and Linux to be different if there are no other elements on the toolbar.
Assignee | ||
Comment 1•9 years ago
|
||
Bug 1192434 - Adjust the vertical padding of the identity box across platforms. r=bgrins
Attachment #8645224 -
Flags: review?(bgrinstead)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Comment on attachment 8645224 [details]
MozReview Request: Bug 1192434 - Adjust the vertical padding of the identity box across platforms. r=bgrins
https://reviewboard.mozilla.org/r/15443/#review13831
In OSX the location bar in a popup window moves down a px or so when being focused with this patch applied
Attachment #8645224 -
Flags: review?(bgrinstead)
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8645224 [details]
MozReview Request: Bug 1192434 - Adjust the vertical padding of the identity box across platforms. r=bgrins
Bug 1192434 - Adjust the vertical padding of the identity box across platforms. r=bgrins
Attachment #8645224 -
Flags: review?(bgrinstead)
Comment 4•9 years ago
|
||
Comment on attachment 8645224 [details]
MozReview Request: Bug 1192434 - Adjust the vertical padding of the identity box across platforms. r=bgrins
https://reviewboard.mozilla.org/r/15443/#review13847
I've tested this on Windows and OSX and it seems to work fine, and does cause popup windows nav height to match normal windows. As far as I understand, this is restoring the margin size previous to Bug 1185362 so it shouldn't cause any problems
Attachment #8645224 -
Flags: review?(bgrinstead) → review+
Comment 6•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
You need to log in
before you can comment on or make changes to this bug.
Description
•