For bug 1121291, we would like to have the password column masked and then unmask individual passwords one-at-a-time of the user's choosing. I couldn't find any way to this with our current <tree> in a way that integrates with the proper OS masking character. Webkit has `-webkit-text-security: disc|square|…;` which would be a somewhat more flexible approach and not XUL-specific but it also seems more complicated and I'm not sure if we want to expose that to the web. I realize there is a moratorium on significant XUL features but there aren't other good solutions that I can see (unless someone can throw together a CSS property patch) without rewriting all the tree logic in HTML which isn't really a good use of time. We would also still need to support that new CSS property in tree cells to solve bug 1121291 without a rewrite.

Bug 1192492 - Support masking of passwords in XUL tree columns.

Comment on attachment 8645313 [details] MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn I think the code is ready for review but this is lacking a reftest as I haven't written them before and wanted to make sure this patch would be accepted before doing that work.

Comment on attachment 8645313 [details] MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn When editing the password (startEditing), you might want to set the textbox type to password.

Thanks Neil, (In reply to Neil Deakin from comment #3) > When editing the password (startEditing), you might want to set the textbox > type to password. I implemented the desired behaviour for our use case in bug 1121291. See https://www.lucidchart.com/documents/edit/87ab1cc8-e708-49d3-8b91-6e2e6da346fb/9 Since this is how we need it to work and we don't want to be adding new generalized XUL features I think this is fine for now.

Comment on attachment 8645313 [details] MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn

Hi Matt, does this bug require QE verification?

Comment on attachment 8645313 [details] MozReview Request: Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn Bug 1192492 - Support masking of passwords in XUL tree columns. r=Enn

Ugh, you should not use the editor guts like this :( https://hg.mozilla.org/integration/mozilla-inbound/rev/7d8d6fef4cfd#l4.12 Please file a follow-up bug and move that method to nsContentUtils and use it from there. Thanks!