Closed
Bug 1192667
Opened 9 years ago
Closed 9 years ago
Transition isn't triggered when you exit DOM fullscreen using F11
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla43
People
(Reporter: arni2033, Assigned: xidorn)
References
(Depends on 1 open bug, Blocks 1 open bug, )
Details
Attachments
(1 file)
|
(deleted),
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
STR: (Win7, Nightly 42.0a1 (2015-08-09))
1. Open any video. E.g. this one: https://www.youtube.com/watch?v=q8e1sSNsf44
2. Click "fullscreen" button on the video
3. Press F11
RESULT: (watch video)
Transition hasn't triggered.
Flags: needinfo?(quanxunzhen)
Oh, I should note that after bug 947854 exiting DOM fullscreen doesn't cause exiting window fullscreen mode, but I hope you'll agree that after Step 3 the transition (fade-through-black) should be triggered
|
Assignee | |
Comment 2•9 years ago
|
||
Well, yes, and this is probably easier to fix than bug 1192664.
|
|
Assignee | |
Comment 3•9 years ago
|
||
Assignee: nobody → quanxunzhen
Attachment #8650796 -
Flags: review?(bugs)
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8650796 [details] [diff] [review]
patch
I guess we can do it this way too.
Another option would be to make F11 handler to use the DOM fullscreen API.
Attachment #8650796 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
url: https://hg.mozilla.org/integration/mozilla-inbound/rev/976e8661ca3c649cbd8bed408193b20852c4a62a
changeset: 976e8661ca3c649cbd8bed408193b20852c4a62a
user: Xidorn Quan <quanxunzhen@gmail.com>
date: Mon Aug 24 09:35:31 2015 +1000
description:
Bug 1192667 - Trigger fullscreen transition when exiting fullscreen via F11. r=smaug
|
||
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
||
Updated•9 years ago
|
QA Whiteboard: [good first verify]
|
||
Comment 7•9 years ago
|
||
I have reproduced this bug by following comment 0 with firefox 42.0a1 (Build ID: 20150809030213; User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:42.0) Gecko/20100101 Firefox/42.0)
The bug is now verified as fixed on latest nightly 45.0a1 (Build ID: 20151207030210; User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0)
You need to log in
before you can comment on or make changes to this bug.
Description
•