Closed
Bug 1192787
Opened 9 years ago
Closed 9 years ago
nsPerformanceTiming::ResponseEndHighRes() does not check whether performance timing is enabled
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: gk, Assigned: qdot)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Looking at https://hg.mozilla.org/mozilla-central/rev/9b0c94f564f3 it seems the check whether performance timing is enabled got removed by accident. This broke actually one of our tests.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → kyle
|
|
Assignee | |
Comment 1•9 years ago
|
||
Not sure why this got removed in the original patch. Fix seems to pass w-p-ts and mochis.
Attachment #8646011 -
Flags: review?(amarchesini)
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8646011 -
Attachment description: 0001-Bug-1192787-Readd-performance-enabled-test-to-Respon.patch → Patch 1 (v1) - Readd performance enabled test to ResponseEndHighRes
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8646011 [details] [diff] [review]
Patch 1 (v1) - Readd performance enabled test to ResponseEndHighRes
Review of attachment 8646011 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/base/nsPerformance.cpp
@@ +348,4 @@
> DOMHighResTimeStamp
> nsPerformanceTiming::ResponseEndHighRes()
> {
> + if (!nsContentUtils::IsPerformanceTimingEnabled() || !IsInitialized()) {
80chars max.
Attachment #8646011 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 4•9 years ago
|
||
My count shows 74 chars for that line. :)
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•