Closed
Bug 1192818
Opened 9 years ago
Closed 8 years ago
Intermittent browser_mediaPlayback_mute.js | Test timed out
Categories
(Core :: DOM: Core & HTML, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox52 | --- | unaffected |
firefox53 | --- | disabled |
firefox54 | --- | disabled |
firefox55 | --- | fixed |
People
(Reporter: RyanVM, Assigned: alwu)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])
Attachments
(6 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
text/x-review-board-request
|
baku
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
baku
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
baku
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
jwwang
:
review+
|
Details |
(deleted),
patch
|
alwu
:
review+
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
22:16:07 INFO - 933 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Event must be dispatched to correct browser.
22:16:07 INFO - 934 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio volume is 1
22:16:07 INFO - 935 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio is not muted
22:16:07 INFO - 936 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio should not be muted by default
22:16:07 INFO - 937 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio should be muted now
22:16:07 INFO - 938 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Event must be dispatched to correct browser.
22:16:07 INFO - 939 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio volume is 0 when muted
22:16:07 INFO - 940 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio is muted
22:16:07 INFO - 941 INFO Leaving test test_frame
22:16:07 INFO - 942 INFO Entering test test_frame
22:16:07 INFO - 943 INFO Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "https://example.com/browser/toolkit/content/tests/browser/file_mediaPlayback2.html" line: 0}]
22:16:07 INFO - 944 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Event must be dispatched to correct browser.
22:16:07 INFO - 945 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio volume is 1
22:16:07 INFO - 946 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio is not muted
22:16:07 INFO - 947 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio should not be muted by default
22:16:07 INFO - 948 INFO TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio should be muted now
22:16:07 INFO - 949 INFO Console message: [JavaScript Error: "1439097334177 Toolkit.Telemetry ERROR TelemetryStorage::loadAbortedSessionPing - error removing ping: PingReadError JS Stack trace: PingReadError@TelemetryStorage.jsm:80:15 < TelemetryStorageImpl.loadPingFile<@TelemetryStorage.jsm:1445:13 < TelemetryStorageImpl.loadAbortedSessionPing<@TelemetryStorage.jsm:1528:20 < this.TelemetryStorage.loadAbortedSessionPing@TelemetryStorage.jsm:303:12 < Impl.checkAbortedSessionPing<@TelemetryController.jsm:557:22 < TaskImpl_run@Task.jsm:314:40 < TaskImpl@Task.jsm:275:3 < createAsyncFunction/asyncFunction@Task.jsm:249:14 < this.TelemetryController<.checkAbortedSessionPing@TelemetryController.jsm:248:12 < setupChromeProcess/this._delayedInitTask<@TelemetrySession.jsm:1462:17 < TaskImpl_run@Task.jsm:314:40 < Handler.prototype.process@Promise-backend.js:934:23 < this.PromiseWalker.walkerLoop@Promise-backend.js:813:7 < Promise*this.PromiseWalker.scheduleWalkerLoop@Promise-backend.js:744:11 < this.PromiseWalker.schedulePromise@Promise-backend.js:776:7 < this.PromiseWalker.completePromise@Promise-backend.js:711:7 < this.BasePromiseWorker.prototype._worker/worker.onmessage@PromiseWorker.jsm:231:9 < EventHandlerNonNull*this.BasePromiseWorker.prototype._worker@PromiseWorker.jsm:217:5 < postMessage@PromiseWorker.jsm:292:9 < TaskImpl_run@Task.jsm:314:40 < Handler.prototype.process@Promise-backend.js:934:23 < this.PromiseWalker.walkerLoop@Promise-backend.js:813:7 < Promise*this.PromiseWalker.scheduleWalkerLoop@Promise-backend.js:744:11 < this.PromiseWalker.schedulePromise@Promise-backend.js:776:7 < Promise.prototype.then@Promise-backend.js:451:5 < this.DeferredSave.prototype._deferredSave@DeferredSave.jsm:219:5 < this.DeferredSave.prototype._startTimer/<@DeferredSave.jsm:174:40 < syncLoadManifestFromFile@XPIProvider.jsm:1308:5 < addMetadata@XPIProvider.jsm:3473:22 < XPI_processFileChanges@XPIProvider.jsm:3754:23 < XPI_checkForChanges@XPIProvider.jsm:3915:34 < XPI_startup@XPIProvider.jsm:2409:25 < callProvider@AddonManager.jsm:221:12 < _startProvider@AddonManager.jsm:703:5 < AMI_startup@AddonManager.jsm:871:9 < AMP_startup@AddonManager.jsm:2511:5 < AMC_observe@addonManager.js:55:7" {file: "resource://gre/modules/Log.jsm" line: 749}]
22:16:07 INFO - 950 INFO Console message: 1439097340855 Toolkit.GMP WARN GMPInstallManager.parseResponseXML got node name: html, expected: updates
22:16:07 INFO - 951 INFO Console message: [JavaScript Error: "1439097340862 Toolkit.GMP ERROR GMPInstallManager.simpleCheckAndInstall Could not check for addons: {"target":{},"message":"got node name: html, expected: updates"}" {file: "resource://gre/modules/Log.jsm" line: 749}]
22:16:07 INFO - 952 INFO Console message: [JavaScript Error: "1439097340930 Toolkit.Telemetry ERROR TelemetryReportingPolicy::get dataSubmissionPolicyNotifiedDate - Invalid date stored." {file: "resource://gre/modules/Log.jsm" line: 749}]
22:16:07 INFO - 953 INFO Console message: 1439097341027 Services.HealthReport.HealthReporter WARN Saved state file does not exist.
22:16:07 INFO - 954 INFO TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Test timed out - expected PASS
22:16:07 INFO - MEMORY STAT | vsize 664MB | residentFast 187MB | heapAllocated 55MB
22:16:07 INFO - 955 INFO TEST-OK | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | took 45723ms
22:16:07 INFO - Not taking screenshot here: see the one that was previously logged
22:16:07 INFO - 956 INFO TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Found a tab after previous test timed out: https://example.com/browser/toolkit/content/tests/browser/file_mediaPlayback2.html - expected PASS
Flags: needinfo?(amarchesini)
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(amarchesini)
Comment 6•9 years ago
|
||
[Mass Closure] Closing Intermittent as a one off
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Status: REOPENED → NEW
Comment hidden (Intermittent Failures Robot) |
Comment 9•8 years ago
|
||
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 19•8 years ago
|
||
This log seems typical:
[task 2017-02-01T23:52:02.178780Z] 23:52:02 INFO - Buffered messages logged at 23:50:38
[task 2017-02-01T23:52:02.183003Z] 23:52:02 INFO - TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Event must be dispatched to correct browser. -
[task 2017-02-01T23:52:02.185162Z] 23:52:02 INFO - TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio volume is 0 when muted -
[task 2017-02-01T23:52:02.188300Z] 23:52:02 INFO - TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio is muted -
[task 2017-02-01T23:52:02.190967Z] 23:52:02 INFO - Leaving test bound test_frame
[task 2017-02-01T23:52:02.192784Z] 23:52:02 INFO - Entering test bound test_frame
[task 2017-02-01T23:52:02.194659Z] 23:52:02 INFO - Buffered messages logged at 23:50:39
[task 2017-02-01T23:52:02.199576Z] 23:52:02 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "https://example.com/browser/toolkit/content/tests/browser/file_mediaPlayback2.html" line: 0}]
[task 2017-02-01T23:52:02.201628Z] 23:52:02 INFO - TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Event must be dispatched to correct browser. -
[task 2017-02-01T23:52:02.203540Z] 23:52:02 INFO - TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio volume is 1 -
[task 2017-02-01T23:52:02.205500Z] 23:52:02 INFO - TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio is not muted -
[task 2017-02-01T23:52:02.208339Z] 23:52:02 INFO - Buffered messages logged at 23:50:44
[task 2017-02-01T23:52:02.211306Z] 23:52:02 INFO - TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio should not be muted by default -
[task 2017-02-01T23:52:02.213223Z] 23:52:02 INFO - TEST-PASS | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Audio should be muted now -
[task 2017-02-01T23:52:02.218972Z] 23:52:02 INFO - Buffered messages finished
[task 2017-02-01T23:52:02.220918Z] 23:52:02 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/browser/browser_mediaPlayback_mute.js | Test timed out -
...so probably hanging near https://dxr.mozilla.org/mozilla-central/rev/e677ba018b22558fef1d07b74d416fd3a28a5dc3/toolkit/content/tests/browser/browser_mediaPlayback_mute.js#70
Comment hidden (Intermittent Failures Robot) |
Comment 21•8 years ago
|
||
:overholt, can you find someone to take a look at this bug and get it resolved in the next 2 weeks. This happend 37 times last week, that is enough that we should be able to reproduce it and find a fix.
Flags: needinfo?(overholt)
Comment 22•8 years ago
|
||
Alastor, can you take a look? If you're too busy to resolve it before the end of February, just let me know. Thanks!
Flags: needinfo?(overholt) → needinfo?(alwu)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → alwu
Flags: needinfo?(alwu)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 26•8 years ago
|
||
When the tab was muted, we should dispatch the DOMAudioPlaybackStopped, but we didn't. This patch can achieve that, but I got some weird test error.
I found that I can't get the "popupshown" event [1] if we dispatch DOMAudioPlaybackStopped after the tab was muted. I don't have idea why it happened.
[1] http://searchfox.org/mozilla-central/rev/cac6cb6a10afb8ebb2ecfbeeedaff7c66f57dd75/browser/base/content/test/general/browser_audioTabIcon.js#76
--
Hi, Jared,
Could you give me some help here?
Thanks!
Flags: needinfo?(jaws)
Comment 27•8 years ago
|
||
I think your issue might be related to how we fade out the icon after DOMAudioPlaybackStopped (see bug 1311799 and bug 1326593), though if the tab is muted we don't fade it out. So it might not be related to that.
Can you get the popup to show when you manually step through what the test is doing?
Flags: needinfo?(jaws)
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 29•8 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #27)
> Can you get the popup to show when you manually step through what the test
> is doing?
Yes, I can get the tooltip when I do it manually.
Assignee | ||
Comment 30•8 years ago
|
||
Hi, Jared,
Do you think whether there is any possible that removing attribute from tab affects the pop-up showing?
I found that I can't get the pop-up even I removed the "sound-playing" attribute without delay (so I just remove that attribute when I got "DOMAudioPlaybackStopped").
And my changing is the tabbrowser would receive the "DOMAudioPlaybackStopped" when calling browser.mute().
Thanks!
Flags: needinfo?(jaws)
Assignee | ||
Comment 31•8 years ago
|
||
Ah, I found a possible reason, it's not related with pop-up, let me debug for more details.
Flags: needinfo?(jaws)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8837407 -
Flags: review?(amarchesini)
Attachment #8839072 -
Flags: review?(amarchesini)
Attachment #8839073 -
Flags: review?(amarchesini)
Comment hidden (mozreview-request) |
Comment 36•8 years ago
|
||
mozreview-review |
Comment on attachment 8837407 [details]
Bug 1192818 - part1 : dispatch DOMAudioPlaybackStopped when mute the tab.
https://reviewboard.mozilla.org/r/112548/#review115530
::: dom/html/HTMLMediaElement.cpp:1004
(Diff revision 3)
>
> AudibleState
> IsOwnerAudible() const
> {
> // Muted or the volume should not be ~0
> - if (mOwner->Muted() || (std::fabs(mOwner->Volume()) <= 1e-7)) {
> + if (mOwner->mMuted != 0 || (std::fabs(mOwner->Volume()) <= 1e-7)) {
remove '!= 0'
Attachment #8837407 -
Flags: review?(amarchesini) → review+
Comment 37•8 years ago
|
||
mozreview-review |
Comment on attachment 8839073 [details]
Bug 1192818 - part3 : modify test.
https://reviewboard.mozilla.org/r/113826/#review115532
Attachment #8839073 -
Flags: review?(amarchesini) → review+
Comment 38•8 years ago
|
||
mozreview-review |
Comment on attachment 8839072 [details]
Bug 1192818 - part2 : only dispatch DOMAudioPlaybackStarted when there is audible sound.
https://reviewboard.mozilla.org/r/113824/#review115534
Attachment #8839072 -
Flags: review?(amarchesini) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 42•8 years ago
|
||
Comment 43•8 years ago
|
||
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38fa2ec33fa4
part1 : dispatch DOMAudioPlaybackStopped when mute the tab. r=baku
https://hg.mozilla.org/integration/autoland/rev/042e5fbe7846
part2 : only dispatch DOMAudioPlaybackStarted when there is audible sound. r=baku
https://hg.mozilla.org/integration/autoland/rev/52f41ac3440d
part3 : modify test. r=baku
Comment 44•8 years ago
|
||
Backed out for frequently failing test_noAudioNotificationOnVolume0Element.html on Android 4.3 debug:
https://hg.mozilla.org/integration/autoland/rev/2a6c1d9fec91e856d3e669f2a93806a088935ca8
https://hg.mozilla.org/integration/autoland/rev/ee46f0aa4132d462a7d3f0f2ed8b395a8615a982
https://hg.mozilla.org/integration/autoland/rev/baead890337d2e56c9d5bb9bc5e6a077f060c84c
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=52f41ac3440dac1609a58ec2b357b9885964773a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=79072729&repo=autoland
[task 2017-02-21T15:36:25.784708Z] 15:36:25 INFO - 219 INFO TEST-START | dom/base/test/test_noAudioNotificationOnVolume0Element.html
[task 2017-02-21T15:36:37.076567Z] 15:36:37 INFO - Buffered messages logged at 15:36:21
[task 2017-02-21T15:36:37.076920Z] 15:36:37 INFO - 220 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | Observer set
[task 2017-02-21T15:36:37.077191Z] 15:36:37 INFO - Buffered messages logged at 15:36:28
[task 2017-02-21T15:36:37.078618Z] 15:36:37 INFO - 221 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | audio-playback received
[task 2017-02-21T15:36:37.079602Z] 15:36:37 INFO - 222 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | This is the right notification
[task 2017-02-21T15:36:37.080534Z] 15:36:37 INFO - 223 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | audio-playback received
[task 2017-02-21T15:36:37.081449Z] 15:36:37 INFO - 224 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | This is the right notification
[task 2017-02-21T15:36:37.082328Z] 15:36:37 INFO - 225 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | audio-playback received
[task 2017-02-21T15:36:37.083214Z] 15:36:37 INFO - 226 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | This is the right notification
[task 2017-02-21T15:36:37.084053Z] 15:36:37 INFO - 227 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | audio-playback received
[task 2017-02-21T15:36:37.084771Z] 15:36:37 INFO - Buffered messages finished
[task 2017-02-21T15:36:37.085757Z] 15:36:37 INFO - 228 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_noAudioNotificationOnVolume0Element.html | This is the right notification - got "inactive-nonaudible", expected "inactive-pause"
[task 2017-02-21T15:36:37.086637Z] 15:36:37 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:310:5
[task 2017-02-21T15:36:37.087394Z] 15:36:37 INFO - observe@dom/base/test/test_noAudioNotificationOnVolume0Element.html:22:7
[task 2017-02-21T15:36:37.088052Z] 15:36:37 INFO - 229 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | audio-playback received
[task 2017-02-21T15:36:37.088713Z] 15:36:37 INFO - 230 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | This is the right notification
[task 2017-02-21T15:36:37.089338Z] 15:36:37 INFO - 231 INFO TEST-PASS | dom/base/test/test_noAudioNotificationOnVolume0Element.html | audio-playback received
[task 2017-02-21T15:36:37.090088Z] 15:36:37 INFO - 232 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_noAudioNotificationOnVolume0Element.html | This is the right notification - got "inactive-pause", expected "inactive-nonaudible"
[task 2017-02-21T15:36:37.090452Z] 15:36:37 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:310:5
[task 2017-02-21T15:36:37.091107Z] 15:36:37 INFO - observe@dom/base/test/test_noAudioNotificationOnVolume0Element.html:22:7
[task 2017-02-21T15:36:37.092166Z] 15:36:37 INFO - 233 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_noAudioNotificationOnVolume0Element.html | should not receive audio-playback notification!
[task 2017-02-21T15:36:37.092557Z] 15:36:37 INFO - observe@dom/base/test/test_noAudioNotificationOnVolume0Element.html:25:7
[task 2017-02-21T15:36:37.093232Z] 15:36:37 INFO - 234 INFO TEST-UNEXPECTED-FAIL | dom/base/test/test_noAudioNotificationOnVolume0Element.html | should not receive audio-playback notification!
[task 2017-02-21T15:36:37.094112Z] 15:36:37 INFO - observe@dom/base/test/test_noAudioNotificationOnVolume0Element.html:25:7
Flags: needinfo?(alwu)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8839814 -
Flags: review?(jwwang)
Comment 49•8 years ago
|
||
mozreview-review |
Comment on attachment 8839814 [details]
Bug 1192818 - part4 : only mute media element if there is alive track.
https://reviewboard.mozilla.org/r/114384/#review116222
::: dom/html/HTMLMediaElement.cpp:2048
(Diff revision 1)
> MOZ_ASSERT((!aTrack->AsAudioTrack() || !aTrack->AsAudioTrack()->Enabled()) &&
> (!aTrack->AsVideoTrack() || !aTrack->AsVideoTrack()->Selected()));
>
> if (aTrack->AsAudioTrack()) {
> + // If we don't have any alive track , we don't need to mute MediaElement.
> + if (AudioTracks()->Length()) {
if (AudioTracks()->Length() > 0)
Attachment #8839814 -
Flags: review?(jwwang) → review+
Assignee | ||
Comment 50•8 years ago
|
||
Flags: needinfo?(alwu)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 55•8 years ago
|
||
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53900c65dbe1
part1 : dispatch DOMAudioPlaybackStopped when mute the tab. r=baku
https://hg.mozilla.org/integration/autoland/rev/ede7e1b58095
part2 : only dispatch DOMAudioPlaybackStarted when there is audible sound. r=baku
https://hg.mozilla.org/integration/autoland/rev/be2f9c0ee32e
part3 : modify test. r=baku
https://hg.mozilla.org/integration/autoland/rev/8ceb12241231
part4 : only mute media element if there is alive track. r=jwwang
Comment 56•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/53900c65dbe1
https://hg.mozilla.org/mozilla-central/rev/ede7e1b58095
https://hg.mozilla.org/mozilla-central/rev/be2f9c0ee32e
https://hg.mozilla.org/mozilla-central/rev/8ceb12241231
Status: NEW → RESOLVED
Closed: 9 years ago → 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Reporter | ||
Comment 57•8 years ago
|
||
It's not clear to me if the underlying problem affects older branches or not. Can you please nominate this for backport if it does?
Flags: needinfo?(alwu)
Assignee | ||
Comment 58•8 years ago
|
||
From the report [1], it seems the issue only happened on m-c/m-i/autoland, so I think we don't need to backport this change.
[1] https://goo.gl/5Gbyu3
Flags: needinfo?(alwu)
Reporter | ||
Updated•8 years ago
|
status-firefox52:
--- → unaffected
status-firefox53:
--- → unaffected
Updated•8 years ago
|
Whiteboard: [stockwell fixed]
Comment hidden (Intermittent Failures Robot) |
Reporter | ||
Comment 61•8 years ago
|
||
Bug 1302280 is happening on Aurora and got duped to this bug. Can you please reconsider? :)
Flags: needinfo?(alwu)
Assignee | ||
Comment 62•8 years ago
|
||
Approval Request Comment
[Feature/Bug causing the regression]: Fix intermittent test case time-out
[User impact if declined]: Still can see the intermittent fail
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No yet, but from the robot's report [1], it seems not happen anymore
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: It doesn't affect daily behavior, only affects test
[String changes made/needed]: No
[1] https://goo.gl/MPLfOn
Flags: needinfo?(alwu)
Attachment #8842278 -
Flags: review+
Attachment #8842278 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•8 years ago
|
Attachment #8842278 -
Attachment is patch: true
Comment 63•8 years ago
|
||
Hi :jmaher,
According to comment #6 in bug 1302280, can you check if this patch fixes the issue?
Flags: needinfo?(jmaher)
Comment 64•8 years ago
|
||
this is fixed and no instances of this since Feb 23rd :)
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1192818&startday=2017-02-20&endday=2017-03-01&tree=all
thanks for fixing this
Flags: needinfo?(jmaher)
Comment 65•8 years ago
|
||
Comment on attachment 8842278 [details] [diff] [review]
Bug 1192818 - dispatch DOMAudioPlaybackStopped when mute the tab. r=baku. (for-aurora)
Fix an intermittent error. Aurora53+.
Attachment #8842278 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment hidden (obsolete) |
Reporter | ||
Comment 67•8 years ago
|
||
Backed out from Beta with IRL a=lizzard for causing bug 1346872 and other regressions.
https://hg.mozilla.org/releases/mozilla-beta/rev/0274a55c5f30
Reporter | ||
Comment 68•8 years ago
|
||
(In reply to Alastor Wu [:alwu] from bug 1346872 comment #46)
> We can also backout the bug 1192818 in 54.
a=you for that? :)
Flags: needinfo?(gchang)
Comment 69•8 years ago
|
||
Hi Ryan,
Yes, please also backout this.
Flags: needinfo?(gchang) → needinfo?(ryanvm)
Reporter | ||
Comment 70•8 years ago
|
||
Backed out from Fx54 too. Had to rebase a little bit, so hopefully it sticks. This remains on mozilla-central (Fx55).
https://hg.mozilla.org/releases/mozilla-aurora/rev/a3d016aadda6
Assignee | ||
Comment 71•8 years ago
|
||
Approval Request Comment
[Feature/Bug causing the regression]: Since this bug was backout from aurora, the intermittent happened again (see bug1302280 comment8). We can disable this test in Aurora, because any uplift patch should still need to pass this test on Nightly.
[User impact if declined]: intermittent fail
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only effect testing
[String changes made/needed]: No
Attachment #8857308 -
Flags: approval-mozilla-aurora?
Reporter | ||
Comment 72•8 years ago
|
||
Comment on attachment 8857308 [details] [diff] [review]
Bug1192818 - disable test in FF54.
This is a test-only change, so it doesn't need approval. Also, it's only failing on Linux debug, so we can use a more targeted skipping. I'll do that accordingly.
Attachment #8857308 -
Attachment is obsolete: true
Flags: needinfo?(ryanvm)
Attachment #8857308 -
Flags: approval-mozilla-aurora?
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(ryanvm)
Reporter | ||
Comment 73•8 years ago
|
||
bugherder uplift |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•