Closed
Bug 1192831
Opened 9 years ago
Closed 9 years ago
Remove PlayPreview API
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox43 fixed)
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: yury, Assigned: yury)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
This will make bug 558184 smaller. We arealready changing two its known users (PDF Viewer and Shumway) to not use the API, so we can remove the API itself.
|
Assignee | |
Comment 1•9 years ago
|
||
Based on the Part 5 patch from bug 1186577 (or bug 558184): rebased and removal another PlayPreview test included.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8649556 -
Flags: review?(bugs)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8649556 [details] [diff] [review]
Remove PlayPreview API
Review of attachment 8649556 [details] [diff] [review]:
-----------------------------------------------------------------
r=me based on these patches basically using identical code used in jsplugins to remove this API
Attachment #8649556 -
Flags: review?(bugs) → review+
|
|
||
Comment 3•9 years ago
|
||
Leaving a NI? for PeterV to look at bug 1186577 again after this lands.
Flags: needinfo?(peterv)
|
|
Assignee | |
Comment 4•9 years ago
|
||
(Updated uuid in nsPluginsHost.idl)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c086584b222
Attachment #8649556 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Updated•9 years ago
|
Attachment #8650753 -
Flags: review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
|
||
Comment 7•9 years ago
|
||
Backed out for suspicion of being the cause of the big spike in bug 1178709 on Windows 8. I'll re-land if that turns out to not be the case.
https://hg.mozilla.org/integration/mozilla-inbound/rev/23649438b3bb
|
|
||
Comment 8•9 years ago
|
||
Confirmed fixed by backout.
|
|
||
Comment 10•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
|
|
||
Updated•6 years ago
|
Flags: needinfo?(peterv)
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•