Closed Bug 1192881 Opened 9 years ago Closed 9 years ago

Make cache2/CacheIndex a member of CacheFileIOManager (deglobalize it)

Categories

(Core :: Networking: Cache, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox43 --- affected

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

Attachments

(1 file, 1 obsolete file)

This opens the door to have more then a single instance of CacheFileIOManager (a.k.a physical storage location) with all its capabilities easily.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Depends on: 1082735
Attached patch v1 (obsolete) (deleted) — Splinter Review
- CacheIndex::gInstance is gone - API changed to be non-static - CacheIndex now member of CacheFileIOManager (refptred) - CacheFileIOManager has now direct and lambda (to prevent cumbersome non-null check all over the code) accessors to its CacheIndex instance - these accessors will update in bug 1032254 to recognize which index to use (gen or pinning) - CacheFileHandle(s) now also carry reference to its CacheFileIOManager (took off the current patch for bug 1032254, made some code much simpler to refactor for this bug and will be needed anyway) - roughly tested https://treeherder.mozilla.org/#/jobs?repo=try&revision=cce974417a48 apply above patch from bug 1082735 to build.
Attachment #8646397 - Flags: review?(michal.novotny)
Attached patch v1 (deleted) — Splinter Review
Attachment #8646397 - Attachment is obsolete: true
Attachment #8646397 - Flags: review?(michal.novotny)
Attachment #8646399 - Flags: review?(michal.novotny)
Comment on attachment 8646399 [details] [diff] [review] v1 Seems like this work is unfortunately lost and not needed. It's bad, since this is a good change that we may need in the future anyway.
Attachment #8646399 - Flags: review?(michal.novotny)
No longer blocks: 1032254
No one needs this right now. We can reopen and take the patches if needed once again.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: