Device: 319MB Flame kk STR: 1. Open Music app, start playing music. 2. Enable usb, and connect the phone to the computer via USB 3. delete all songs on the phone 4. Disconnect USB Actual: The music is gone, but the status bar still shows playback icon Expected: Playback icon should be gone Version info: Serial: e474dac3 (State: device) Build ID 20150811030209 Gaia Revision 9a8880a95ee4a4aea7895d4e2bcab31bc49ea281 Gaia Date 2015-08-10 16:01:11 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/8cba870a352c Gecko Version 43.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150811.062158 Firmware Date Tue Aug 11 06:22:11 EDT 2015 Bootloader L1TC000118D0

This bug can be repro in both OGA music and NGA music on latest build of Flame KK v2.5, as well as in NGA music on Aries KK v2.5, it cannot repro in OGA music on Flame KK v2.2, but the results are not the same in comment 0. Results: After user deletes all the songs by USB, the playing song in device will not stop and user can see it in Control bar at the notification page and the playback icon on the status bar ; Launch Music app, it shows add songs to get start while the song is playing. Attachments:logcat1759.txt & Flame kk v2.5.3gp Rate:10/10 Flame KK 2.5 (Affected) Build ID 20151007150205 Gaia Revision b99837aa2294348317bcae68acabe71d9a83d774 Gaia Date 2015-10-07 13:04:16 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/1e1fa696e2b626ead6817b7c5bd871fec5d5ab5a Gecko Version 44.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151007.183338 Firmware Date Wed Oct 7 18:33:51 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 AriesKK v2.5 (Affected) Build ID 20151008002716 Gaia Revision b99837aa2294348317bcae68acabe71d9a83d774 Gaia Date 2015-10-07 13:04:16 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/c6ede6f30f3dc886543bb1c76fd7c8b5a151786b Gecko Version 44.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151007.234555 Firmware Date Wed Oct 7 23:46:03 UTC 2015 Bootloader s1 Flame KK 2.2 (Unaffected) Build ID 20151007032507 Gaia Revision 5dd95cfb9f1d6501ce0e34414596ef3dd9c2f583 Gaia Date 2015-09-21 11:20:23 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b48f0cd1bc45 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151007.064847 Firmware Date Wed Oct 7 06:48:58 EDT 2015 Firmware Version v18D v4 Bootloader L1TC000118D0

Ok, so the only bug here is that we show the "add songs to get started" overlay even though we're playing music. It's perfectly valid for the current song to continue playing even though it was deleted, since we still have a valid file descriptor for it (and we wouldn't be able to easily tell if you only deleted the current song). I think the solution here is "don't show the overlays if we're currently playing music". Thoughts?

(In reply to Jim Porter (:squib) from comment #4) > Ok, so the only bug here is that we show the "add songs to get started" > overlay even though we're playing music. It's perfectly valid for the > current song to continue playing even though it was deleted, since we still > have a valid file descriptor for it (and we wouldn't be able to easily tell > if you only deleted the current song). > > I think the solution here is "don't show the overlays if we're currently > playing music". Thoughts? I agree with squib on this. The real bug here is that the "no songs" overlay should not appear if you are still playing music after having just deleted all your songs over USB. This seems like an *extreme* edge case though. I will rename the bug to track fixing it.

Deleted music should not be playing on the device. If the user deletes a song, the user is not going to expect it to be playing. In the case of removing all songs from Music, the overlay should be shown and the play icon should be removed from the status bar. ~Your friends at the UX triage!

(In reply to Tiffanie Shakespeare [:tif] UX from comment #6) > Deleted music should not be playing on the device. If the user deletes a > song, the user is not going to expect it to be playing. > > In the case of removing all songs from Music, the overlay should be shown > and the play icon should be removed from the status bar. > > ~Your friends at the UX triage! If the song was being played at the time of the deletion, the song is still in-memory and the file handle is technically still open which is why it is still playing.

It would be quite surprising to me if I deleted a folder from my SD card and it interrupted the music that was currently playing; the two actions don't have an obvious relationship to me. It's also a lot of extra work to track and respond to that information, especially for an extreme edge case like this. Really, I think the ideal would be a warning when you try to delete a file you're using somewhere else, but I'm not sure MTP really allows for that. And again, that might be a lot of extra work for such a small edge case. I'm not convinced users will encounter this in the real world.

As we discussed on IRC, we should determine the path of least resistance to solving this (either forcefully stop playing the song and go back -or- prevent showing the overlay if a song is already playing). Since this is a highly unlikely real-world scenario, we should avoid dedicating a significant chunk of code towards it if we can (this will help prevent future regressions and reduce maintenance overhead for the codebase).

[Tracking Requested - why for this release]: Per comment 9, moving it to the backlog. I also think this might be something to do with the filesystem limitation. Also in order to accomplish Comment 6, it would basically require a new feature as well.

Firefox OS is not being worked on