Closed Bug 119373 Opened 23 years ago Closed 9 years ago

workaround apache double-zip bug when sending .zip files (duplicate the double-gzip logic in nsHttpChannel.cpp)

Categories

(Core :: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: darin.moz, Unassigned)

Details

Attachments

(1 obsolete file)

workaround apache double-zip bug when sending .zip files (duplicate the double-gzip logic in nsHttpChannel.cpp). see nsHttpChannel::ProcessNormal() bz says apache does not exhibit this bug by default... only if configured to automatically send "Content-Encoding: deflate" for .zip files. the same logic should probably be in place for compress as well.
Oh, and "compress" is _on_ by default, by the way. At least in the default RedHat 6.2 Apache install....
Attached patch Proposed fix (obsolete) (deleted) — Splinter Review
So... the site sends the file as application/x-gunzip. The patch adds that to the nsHttpChannel "apache is broken" logic and adds postscript to the list of types not to decode (a good idea anyway, imo).
Comment on attachment 71814 [details] [diff] [review] Proposed fix um... wrong bug. :(
Attachment #71814 - Attachment is obsolete: true
-> future
Target Milestone: --- → Future
-> default owner
Assignee: darin → nobody
Component: Networking: HTTP → Networking
QA Contact: tever → networking
Target Milestone: Future → ---
Boris: Is this bug fixed by bug 717524 ?
No. That bug is about doubled gzip content-encoding. This bug is about a misconfigured server claiming that a .zip file is content-encoded with "compress", which causes us to decompress it when we should not.
I'm going to close this without a gecko change. the server is at fault, and we aren't overrun with this report so there is no reason to implement a workaround for it.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: