This doesn't seem to fire.

I was told a while ago that this was probably going to be removed from the spec (since we already have null candidates), but that does not seem to have happened. Should be an easy fix.

Comment on attachment 8812463 [details] Bug 1193731: basic ICE gathering state verification in mochitests https://reviewboard.mozilla.org/r/94198/#review94580 Looks good to me.

Comment on attachment 8812465 [details] Bug 1193731: add missing handlers for icegatheringstatechange https://reviewboard.mozilla.org/r/94202/#review94658 lgtm with thing fixed. ::: dom/media/PeerConnection.js:1219 (Diff revision 1) > changeIceGatheringState: function(state) { > this._iceGatheringState = state; > _globalPCList.notifyLifecycleObservers(this, "icegatheringstatechange"); > + this.dispatchEvent(new this._win.Event("icegatheringstatechange")); > }, Spec says [1] "If connection's [[isClosed]] slot is true or connection's ice connection state has the same value as newState, abort these steps." So we should probably check those things here. [1] http://w3c.github.io/webrtc-pc/#update-ice-gathering-state

Comment on attachment 8812533 [details] Bug 1193731: onicegatheringstatechange web-platformtests should pass https://reviewboard.mozilla.org/r/94242/#review94664

Comment on attachment 8812465 [details] Bug 1193731: add missing handlers for icegatheringstatechange https://reviewboard.mozilla.org/r/94202/#review94658 > Spec says [1] "If connection's [[isClosed]] slot is true or connection's ice connection state has the same value as newState, abort these steps." > > So we should probably check those things here. > > [1] http://w3c.github.io/webrtc-pc/#update-ice-gathering-state If I'm not mistaken dispatchEvent() is suppose to take care of the |isClosed| case already, so I only added checks for no state change.

Comment on attachment 8812464 [details] Bug 1193731: add missing onicegatheringstatechange to WebIDL https://reviewboard.mozilla.org/r/94200/#review94698 rs=me if jib say this matches the spec.

Pushed by drno@ohlmeier.org: https://hg.mozilla.org/integration/autoland/rev/907917f2785e add missing onicegatheringstatechange to WebIDL r=bholley https://hg.mozilla.org/integration/autoland/rev/4b2b12f1fa7c add missing handlers for icegatheringstatechange r=jib https://hg.mozilla.org/integration/autoland/rev/4fb6e8e03e3a basic ICE gathering state verification in mochitests r=mjf https://hg.mozilla.org/integration/autoland/rev/79bfdfbb78aa onicegatheringstatechange web-platformtests should pass r=jib

https://hg.mozilla.org/mozilla-central/rev/907917f2785e https://hg.mozilla.org/mozilla-central/rev/4b2b12f1fa7c https://hg.mozilla.org/mozilla-central/rev/4fb6e8e03e3a https://hg.mozilla.org/mozilla-central/rev/79bfdfbb78aa