20:21:34 INFO - 2677 INFO Checking the right node is selected 20:21:34 INFO - 2678 INFO TEST-PASS | browser/devtools/markupview/test/browser_markupview_navigation.js | Found node: html after pressing left 20:21:34 INFO - 2679 INFO Testing step: down to navigate to html 20:21:34 INFO - 2680 INFO Making sure markup-view children get updated 20:21:34 INFO - 2681 INFO Waiting for queued children updates to be handled 20:21:34 INFO - 2682 INFO Checking the right node is selected 20:21:34 INFO - 2683 INFO TEST-PASS | browser/devtools/markupview/test/browser_markupview_navigation.js | Found node: html after pressing down 20:21:34 INFO - 2684 INFO Leaving test 20:21:34 INFO - TEST-INFO | started process screentopng 20:21:37 INFO - TEST-INFO | screentopng: exit 0 20:21:37 INFO - 2685 INFO checking window state 20:21:37 INFO - 2686 INFO TEST-UNEXPECTED-FAIL | browser/devtools/markupview/test/browser_markupview_navigation.js | A promise chain failed to handle a rejection: - at resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1125 - Error: Connection closed, pending request to server1.conn29.child1/highlighter27, type showBoxModel failed 20:21:37 INFO - Request stack: 20:21:37 INFO - Front<.request@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1178:7 20:21:37 INFO - frontProto/</proto[name]@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1330:14 20:21:37 INFO - exports.getHighlighterUtils/exported.highlightNodeFront<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox-highlighter-utils.js:212:13 20:21:37 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:314:40 20:21:37 INFO - TaskImpl@resource://gre/modules/Task.jsm:275:3 20:21:37 INFO - createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14 20:21:37 INFO - Task_spawn@resource://gre/modules/Task.jsm:164:12 20:21:37 INFO - TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:381:1 20:21:37 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:322:13 20:21:37 INFO - TaskImpl@resource://gre/modules/Task.jsm:275:3 20:21:37 INFO - createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:249:14 20:21:37 INFO - MarkupView.prototype._showBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:313:12 20:21:37 INFO - MarkupView.prototype._brieflyShowBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:339:5 20:21:37 INFO - MarkupView.prototype._onNewSelection@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:453:7 20:21:37 INFO - EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/event-emitter.js:147:11 20:21:37 INFO - Selection.prototype.setNodeFront@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/selection.js:179:5 20:21:37 INFO - MarkupView.prototype.markNodeAsSelected@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:1239:7 20:21:37 INFO - MarkupView.prototype.navigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:716:5 20:21:37 INFO - MarkupView.prototype._onKeyDown@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:596:11 20:21:37 INFO - synthesizeKey@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:662:7 20:21:37 INFO - pressKey@chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_navigation.js:94:7 20:21:37 INFO - @chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_navigation.js:78:5 20:21:37 INFO - TaskImpl_run@resource://gre/modules/Task.jsm:314:40 20:21:37 INFO - Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:934:23 20:21:37 INFO - this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:813:7 20:21:37 INFO - Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:11 20:21:37 INFO - this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:776:7 20:21:37 INFO - this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:711:7 20:21:37 INFO - testScope/test_executeSoon/<.run@chrome://mochikit/content/browser-test.js:957:9 20:21:37 INFO - Stack trace: 20:21:37 INFO - Front<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1125:23 20:21:37 INFO - Pool<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:820:9 20:21:37 INFO - Front<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:1127:5 20:21:37 INFO - exports.InspectorFront<.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:3723:5 20:21:37 INFO - Toolbox.prototype.destroyInspector/this._destroyingInspector<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:1766:13 20:21:37 INFO - MarkupView.prototype._showBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:313:12 20:21:37 INFO - MarkupView.prototype._brieflyShowBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:339:5 20:21:37 INFO - MarkupView.prototype._onNewSelection@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:453:7 20:21:37 INFO - EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/event-emitter.js:147:11 20:21:37 INFO - Selection.prototype.setNodeFront@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/selection.js:179:5 20:21:37 INFO - MarkupView.prototype.markNodeAsSelected@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:1239:7 20:21:37 INFO - MarkupView.prototype.navigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:716:5 20:21:37 INFO - MarkupView.prototype._onKeyDown@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:596:11 20:21:37 INFO - synthesizeKey@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:662:7 20:21:37 INFO - pressKey@chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_navigation.js:94:7 20:21:37 INFO - @chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_navigation.js:78:5 20:21:37 INFO - MarkupView.prototype._showBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:313:12 20:21:37 INFO - MarkupView.prototype._brieflyShowBoxModel@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:339:5 20:21:37 INFO - MarkupView.prototype._onNewSelection@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:453:7 20:21:37 INFO - EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/event-emitter.js:147:11 20:21:37 INFO - Selection.prototype.setNodeFront@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/selection.js:179:5 20:21:37 INFO - MarkupView.prototype.markNodeAsSelected@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:1239:7 20:21:37 INFO - MarkupView.prototype.navigate@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:716:5 20:21:37 INFO - MarkupView.prototype._onKeyDown@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/markupview/markup-view.js:596:11 20:21:37 INFO - synthesizeKey@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:662:7 20:21:37 INFO - pressKey@chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_navigation.js:94:7 20:21:37 INFO - @chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_navigation.js:78:5 20:21:37 INFO - testScope/test_finish/<@chrome://mochikit/content/browser-test.js:1055:11 20:21:37 INFO - testScope/test_executeSoon/<.run@chrome://mochikit/content/browser-test.js:957:9

This test ends before a request could complete (showBoxModel, which is used to briefly highlight a node after selection). Depending on how fast this request is handled, it could still be pending by the time the test ends, therefore causing the intermittent failure. The test should wait for the inspector-updated event everytime a node is selected. This would make sure the highlighting was done.

This should work. r=test-only https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5094ee1f446

Backed out for causing intermittent browser_markupview_navigation.js timeouts. https://treeherder.mozilla.org/logviewer.html#?job_id=4415705&repo=fx-team https://treeherder.mozilla.org/logviewer.html#?job_id=4418237&repo=fx-team https://hg.mozilla.org/integration/fx-team/rev/9432c30af5bd