Closed
Bug 1194278
Opened 9 years ago
Closed 8 years ago
Animations displayed in the timeline UI should be updated when their playback rates is changed
Categories
(DevTools :: Inspector: Animations, defect, P2)
DevTools
Inspector: Animations
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1194639
People
(Reporter: pbro, Unassigned)
References
Details
(Whiteboard: [devtools-platform])
The v2 animation-inspector UI (bug 1120900) is entirely based on the UI polling the backend, which makes it straight-forward to react to any sort of changes on the animation side.
v3 however (bug 1153271) isn't based on polling, and I intend to keep it this way.
Now that I'm working on implementing this new UI (and in particular representing the playback rate), I need a way to update the display of an animation if its rate is changed from content.
There seems to be no events that I can listen to that will tell me this. I don't think the spec defines an event for this, and the MutationObserver which we're using to detect when animations are added, removed or changed, doesn't seem to report anything when the rate changes.
Reporter | ||
Comment 1•9 years ago
|
||
Brian: Is there anything planned in the spec for this?
Cameron: Do you think this is something we could add to the MutationObserver?
Flags: needinfo?(cam)
Flags: needinfo?(bbirtles)
Comment 2•9 years ago
|
||
(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #1)
> Brian: Is there anything planned in the spec for this?
> Cameron: Do you think this is something we could add to the MutationObserver?
If the playbackRate changes, we should notify mutation observers. It looks like we don't because I think we didn't support setting the playbackRate when Cameron implemented the mutation observers.
On a related note, do you want to be notified if script modifies the currentTime? Or startTime? Or is paused/resumed?
I think when we did the mutation observers we weren't really thinking about script modification since we're not shipping those interfaces in release builds yet. Since we hope to ship part of those interfaces by roughly the end of Q3 we should probably fix that.
Flags: needinfo?(bbirtles)
Reporter | ||
Comment 3•9 years ago
|
||
(In reply to Brian Birtles (:birtles) from comment #2)
> If the playbackRate changes, we should notify mutation observers.
Cool!
> It looks
> like we don't because I think we didn't support setting the playbackRate
> when Cameron implemented the mutation observers.
Yeah, that makes sense.
> On a related note, do you want to be notified if script modifies the
> currentTime? Or startTime? Or is paused/resumed?
Yes, this would definitely help.
> I think when we did the mutation observers we weren't really thinking about
> script modification since we're not shipping those interfaces in release
> builds yet. Since we hope to ship part of those interfaces by roughly the
> end of Q3 we should probably fix that.
I'll file a bug for this.
Thanks.
Reporter | ||
Updated•9 years ago
|
Whiteboard: [devtools-platform]
Reporter | ||
Updated•9 years ago
|
Reporter | ||
Updated•9 years ago
|
Flags: needinfo?(cam)
Reporter | ||
Updated•9 years ago
|
Component: Developer Tools: Inspector → Developer Tools: Animation Inspector
Comment 4•8 years ago
|
||
Inspector bug triage. Filter on CLIMBING SHOES.
As I understand the summary, the animation inspector might display incorrect information -> P2.
Priority: -- → P2
Comment 5•8 years ago
|
||
Looks like I fixed this in bug 1194639.
Specifically here: https://hg.mozilla.org/mozilla-central/rev/90370e8e13f2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•