Closed Bug 1194575 Opened 9 years ago Closed 9 years ago

Rename RasterImage::RecoverFromLossOfFrames() to something more sensible

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox43 --- fixed

People

(Reporter: seth, Assigned: seth)

References

Details

Attachments

(1 file)

Rename RecoverFromLossOfFrames() to RecoverFromInvalidFrames() to better reflect its role
(deleted), patch
tnikkel
: review+
Details | Diff | Splinter Review
After bug 1194059, RecoverFromLossOfFrames() is called not only in response to a GPU reset, but also if a corrupt GIF fooled us into thinking an image wasn't animated when it really was. We should rename it (and probably update the NS_WARNING that it prints) to better capture this dual role.
I renamed RecoverFromLossOfFrames() to RecoverFromInvalidFrames() and updated the comment and the NS_WARNING message.
Attachment #8648306 - Flags: review?(tnikkel)
Attachment #8648306 - Flags: review?(tnikkel) → review+
https://hg.mozilla.org/mozilla-central/rev/8d3dbbed86c6
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: