Closed
Bug 1194906
Opened 9 years ago
Closed 9 years ago
Replace NS_ENSURE_TRUE(BadImage(...)) warning messages with more comprehensible warnings
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: seth, Assigned: seth)
Details
Attachments
(1 file)
(deleted),
patch
|
tnikkel
:
review+
|
Details | Diff | Splinter Review |
ImageFactory has this NS_ENSURE_TRUE(BadImage(...)) pattern that it uses to mark an image as having an error, print a warning, and return the image to the caller, all at the same time.
NS_ENSURE_TRUE is no longer consider good Mozilla style, and the resulting log messages don't mean much to people who don't work on ImageLib. Let's get rid of the NS_ENSURE_TRUE part and make the messages a *bit* more useful.
Updated•9 years ago
|
Attachment #8648310 -
Flags: review?(tnikkel) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Comment 3•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•