Closed
Bug 1195006
Opened 9 years ago
Closed 9 years ago
Missing files in blobfree distribution should completely stop the process
Categories
(Firefox OS Graveyard :: B2gInstaller, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S5 (21Aug)
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
Capture d'écran de 2015-08-15 16-52-01-1.png
Right now, if we lack for example recovery.fstab, there will be an error but the process will continue. We should not do this.
|
Assignee | |
Comment 1•9 years ago
|
||
Assignee: nobody → lissyx+mozillians
Status: NEW → ASSIGNED
Attachment #8648473 -
Flags: review?(dale)
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → FxOS-S5 (21Aug)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8648473 [details]
PR
I dont love the large amount of extra error handling here, we already track what step we are in for the UX and if we just want to be able to display that for users debugging we can add some state to store which step we are in @ https://github.com/mozilla-b2g/b2g-installer/blob/master/about.js#L992 and have that console.log'd in the single try catch.
+1 for the properly rejecting in the distribution step though
Attachment #8648473 -
Flags: review?(dale)
|
|
Assignee | |
Comment 3•9 years ago
|
||
Okay, those extra were useful for tracking at the console level. I'll retest without all of them.
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8648473 -
Flags: review?(dale)
|
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8648473 [details]
PR
Awesome thanks, looks great
Attachment #8648473 -
Flags: review?(dale) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•