Closed
Bug 1195246
Opened 9 years ago
Closed 9 years ago
Port client.mk changes from |Bug 1188766 - sccache setup with UPLOAD_EXTRA_FILES makes some files uploaded multiple times| to comm-central
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(firefox43 affected)
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | affected |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
The mozconfig.cache changes were ported in:
https://hg.mozilla.org/comm-central/rev/b1c282fe435af169b2a46df96aed132eadb95b87
There are still changes to client.mk from the other part of bug 1188766
Attachment #8648671 -
Flags: review?(aleth)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8648671 [details] [diff] [review]
Port UPLOAD_EXTRA_FILES changes
Review of attachment 8648671 [details] [diff] [review]:
-----------------------------------------------------------------
I'm not a build config peer.
Attachment #8648671 -
Flags: review?(aleth) → review?(Pidgeot18)
|
|
||
Comment 2•9 years ago
|
||
Thanks for spotting this though!
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8648671 [details] [diff] [review]
Port UPLOAD_EXTRA_FILES changes
Review of attachment 8648671 [details] [diff] [review]:
-----------------------------------------------------------------
I'm going to cancel all reviews involving client.mk. Within a few months, we're going to have to end up merging m-c and c-c one way or another, and the current comm-central client.mk will disappear at that point. Client.mk is very difficult to trust changes, since it sometimes has to support not having m-c present, so this is high risk and low value.
Attachment #8648671 -
Flags: review?(Pidgeot18)
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•