Closed
Bug 1195364
Opened 9 years ago
Closed 9 years ago
Create an acceptance test which checks that "Pressing home button does nothing on the lockscreen"
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Attachments
(1 file)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → jlorenzo
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
The PR is ready.
Job to check the flakiness of the new test: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/867/console
Job that checks that no b2g test is broken: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/868/console
Assignee | ||
Comment 3•9 years ago
|
||
No flakiness to report but I did break some tests. I'll investigate them.
Assignee | ||
Comment 4•9 years ago
|
||
Updated PR, let's create new jobs.
Flakiness: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/871/console
Brokenness: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/870/console
Assignee | ||
Comment 5•9 years ago
|
||
The brokenness job in comment 4 lost the connection to b2g. Same thing for the following job: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/872/console
I'll try to split the job into 2 to see if we can get more reliable results.
Assignee | ||
Comment 6•9 years ago
|
||
The connection lost from b2g was due to a gecko bug. Retrying http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/881/
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8649891 [details]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master
I got a build that shows that no regression happened in the test suite: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/882/consoleFull
The test is not flaky: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/871/console
What do you guys think?
Attachment #8649891 -
Flags: review?(martijn.martijn)
Attachment #8649891 -
Flags: review?(jdorlus)
Comment 9•9 years ago
|
||
Comment on attachment 8649891 [details]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master
I added some comments/questions/suggestions in the pull request.
I'm more wondering about these ._handle_home_button_event_in_homescreen/_handle_home_button_event_in_lockscreen methods.
It seems to me like it would be better if you wrote separate tests for these, instead of adding this as part of touch_home_button().
Something like test_homescreen_home_button_edit_mode.py for example, or something like that.
What do you think?
Attachment #8649891 -
Flags: review?(martijn.martijn)
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8649891 [details]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master
Thanks for the review! The point you raised caught a false positive. I updated the test.
Concerning _handle_home_button_event_in_homescreen() and _handle_home_button_event_in_lockscreen(), I created 2 other tests in the PR, in order to check that these paths are covered.
I'm not sure what you mean by not putting this calls in touch_home_button(). The home button doesn't have the same behavior depending on where you press on it. Hence, having the behavior centralized there sounds closer to what the button should do. What do you think?
Attachment #8649891 -
Flags: review?(martijn.martijn)
Comment 11•9 years ago
|
||
Comment on attachment 8649891 [details]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master
(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #10)
> I'm not sure what you mean by not putting this calls in touch_home_button().
> The home button doesn't have the same behavior depending on where you press
> on it. Hence, having the behavior centralized there sounds closer to what
> the button should do. What do you think?
Sorry, you're right. This is already done here and it's the most logical thing to do.
I did some testing and everything passed.
Attachment #8649891 -
Flags: review?(martijn.martijn) → review+
Comment 12•9 years ago
|
||
Comment on attachment 8649891 [details]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master
Sorry this took so long.
Attachment #8649891 -
Flags: review?(jdorlus) → review+
Assignee | ||
Comment 13•9 years ago
|
||
FYI: Still waiting on bug 1188926 to land this patch.
Comment 14•9 years ago
|
||
Johan, bug 1188926 is fixed now, so I guess this pull request can be merged now or is this not useful anymore?
Flags: needinfo?(jlorenzo)
Assignee | ||
Comment 15•9 years ago
|
||
Like discussed back in the work week, these tests would have more value as a Gij one. They only verify the integration between gecko and gaia (we emulate the home button being pressed thanks to some Gaia code).
I couldn't find any equivalent in the Gij suite. I filed bug 1232280 and bug 1232281 to implement them.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(jlorenzo)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•