Closed Bug 1195602 Opened 9 years ago Closed 9 years ago

[GPS] Support SUPL NI case in Gaia

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.2r+, b2g-v2.2 wontfix, b2g-v2.2r fixed)

Status:
RESOLVED FIXED
Project Flags:
feature-b2g 2.2r+
Tracking Flags:
Tracking Status
b2g-v2.2 --- wontfix
b2g-v2.2r --- fixed

People

(Reporter: lchang, Assigned: lchang)

References

Details

User Story

As a FxOS user, I want to be notified of a SUPL Network Initiated request for my location that gives me the ability to approve or cancel it, so that I can control my location privacy.

As an Operator, I want to SUPL notify-verify call flow to be supported on my devices, so that I can deploy network location services in compliance with specs which mandate ni notify-verify call flow.

Attachments

(4 files, 1 obsolete file)

[gaia] luke-chang:1195602_v2.2_supl_ni > mozilla-b2g:v2.2
(deleted), text/x-github-pull-request
johnhu
: review+
Details
Location icons.zip
(deleted), application/zip
Details
screenshots_v2
(deleted), application/zip
harly
: ui-review+
Details
[gaia] luke-chang:1195602_v2.2r_supl_ni > mozilla-b2g:v2.2r
(deleted), text/x-github-pull-request
Details
+++ This bug was initially created as a clone of Bug #853703 +++ For the sake of convenience, this bug is cloned for reviewing the associated patch in Gaia part.
Comment on attachment 8649087 [details] [gaia] luke-chang:1195602_v2.2_supl_ni > mozilla-b2g:v2.2 Hi John, Could you take a look at this patch? I can demo the whole scenario to you face to face.
Attachment #8649087 - Flags: review?(im)
Attached file screenshots (obsolete) (deleted) —
Hi Harly, Please refer to the attached screenshots. I can demo it on real device if necessary. Thanks a lot.
Attachment #8650339 - Flags: ui-review?(hhsu)
Sorry, I forgot to explain the screenshots in comment 3. - 01.png & 02.png are for notification. - 03.png is for verification. - 04.png is also for verification but happens only when screen is locked. It triggers notification first and will show the dialog (the same as what in 03.png) right after clicking the notification manually.
Hi Luke, After consulting with the visuals, we think it is kind of strange not to have an icon beside the notification, do you think we can design a icon and placed on notification?
Flags: needinfo?(lchang)
Sure, it would be much better if there is an icon. Thanks in advance.
Flags: needinfo?(lchang)
Helen, could you provide the icon for the notification? Thanks
Flags: needinfo?(hhuang)
Comment on attachment 8649087 [details] [gaia] luke-chang:1195602_v2.2_supl_ni > mozilla-b2g:v2.2 looks good to me. Please add some comments to code to tell us more.
Attachment #8649087 - Flags: review?(im) → review+
Attached file Location icons.zip (deleted) —
Images attached! Let me know if any questions.
Flags: needinfo?(hhuang)
Attached file screenshots_v2 (deleted) —
Helen, Thanks a lot. Harly, Please take a look at these updated screenshots. Thanks.
Attachment #8650339 - Attachment is obsolete: true
Attachment #8650339 - Flags: ui-review?(hhsu)
Attachment #8652195 - Flags: ui-review?(hhsu)
According to the building blocks guideline defined here :https://developer.mozilla.org/en-US/Apps/Design/Firefox_OS_building_blocks/Dialog The dialog with only a single OK button should use grey color instead of blue.
According to the document, I think it should be fixed on master branch as well. However, this patch may not be landed on master. Since Modal Dialog is a stand-alone module, I would suggest filing another bug to fix the color of the button and review the rest here. What do you think?
Flags: needinfo?(hhsu)
After an offline discussion with Luke, I agree that this is a modal dialog bug and we should probably address this in another bug.
Flags: needinfo?(hhsu)
Comment on attachment 8652195 [details] screenshots_v2 Looks good to me, thanks for the awesome work!
Attachment #8652195 - Flags: ui-review?(hhsu) → ui-review+
Harly, Thanks. Bug 1199537 is filed for the color issue of the button.
Cherry-picked the patch to v2.2r since we've decided not to land this feature on v2.2. Will land it after tests are all passed.
status-b2g-v2.2: affected → wontfix
status-b2g-v2.2r: --- → affected
Blocks: red-square
feature-b2g: --- → 2.2r+
No longer depends on: 853703
Depends on: 853703
According to Bug 1195872, gaia-try on v2.2r is totally broken now. I'd suggest landing this patch after that is fixed if not urgent. Hi Wesly, what do you think?
Depends on: 1195872
Flags: needinfo?(wehuang)
Agree w/ Luke, even the plan is to implement this feature in 2.2r we don't need to rush for it when gaia-try is broken. We can wait for some time before landing it. Thanks. (In reply to Luke Chang [:lchang] from comment #18) > According to Bug 1195872, gaia-try on v2.2r is totally broken now. I'd > suggest landing this patch after that is fixed if not urgent. > > Hi Wesly, what do you think?
Flags: needinfo?(wehuang)
Comment on attachment 8655945 [details] [gaia] luke-chang:1195602_v2.2r_supl_ni > mozilla-b2g:v2.2r Bug 1195872 has resolved. Let's try again.
The gaia-try has recovered but one of the lockscreen tests is still failed (bug 1204859).
Depends on: 1204859
Finally, tests are all passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=89b6e84d7dcee2996e28dd18e9aa3c1c39164ee2 landed on v2.2r: https://github.com/mozilla-b2g/gaia/commit/d52d714afd14c6253ddac8fab63f29b8bcf59f2b Please note that this patch needs to work with the Gecko patch in bug 853703.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-b2g-v2.2r: affected → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: