Closed
Bug 1195685
Opened 9 years ago
Closed 9 years ago
Transform macro |BT_APPEND_NAMED_VALUE| into function
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(blocking-b2g:2.2r+, firefox43 fixed, b2g-v2.2r fixed, b2g-master fixed)
People
(Reporter: ben.tian, Assigned: ben.tian)
References
Details
Attachments
(2 files, 4 obsolete files)
Per bug 1180554 comment 6, we need to transform |BT_APPEND_NAMED_VALUE| into function to use it with variables.
|
Assignee | |
Comment 1•9 years ago
|
||
Patch based on current m-c. Will revise PBAP and MAP after they are landed.
|
|
Assignee | |
Comment 2•9 years ago
|
||
Rebased on bug 1180556 with PBAP change.
Attachment #8649194 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•9 years ago
|
||
Attachment #8654782 -
Flags: review?(shuang)
|
|
Assignee | |
Updated•9 years ago
|
Comment on attachment 8654782 [details] [diff] [review]
[2.2r] Patch 1 (v1): Transform macro |BT_APPEND_NAMED_VALUE| into function
Review of attachment 8654782 [details] [diff] [review]:
-----------------------------------------------------------------
Code looks good.
::: dom/bluetooth/bluedroid/BluetoothPbapManager.cpp
@@ +506,5 @@
> }
>
> switch (aTagId) {
> case AppParameterTag::Order: {
> + AppendNamedValue(aValues, "order", (uint32_t) buf[0]);
Please use static casting instead of c-style casting, use |static_cast<uint32_t>|.
@@ +511,4 @@
> break;
> }
> case AppParameterTag::SearchProperty: {
> + AppendNamedValue(aValues, "searchKey", (uint32_t) buf[0]);
Ditto.
Attachment #8654782 -
Flags: review?(shuang) → review+
|
|
Assignee | |
Comment 5•9 years ago
|
||
Revise per reviewer's comment.
Attachment #8654782 -
Attachment is obsolete: true
Are you going to land on m-c?
Flags: needinfo?(btian)
Blocks: 1166675
Blocks: 1166679
Blocks: 1186836
Blocks: 1195710
|
|
Assignee | |
Comment 7•9 years ago
|
||
I'll land to m-c after dependent PBAP bugs are landed.
Flags: needinfo?(btian)
|
|
Assignee | |
Comment 8•9 years ago
|
||
Rebase on the latest m-c.
Attachment #8649744 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 9•9 years ago
|
||
Remove redundant API v1 code.
Attachment #8658499 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 10•9 years ago
|
||
|
|
Assignee | |
Comment 12•9 years ago
|
||
Set 2.2r+ blocker since this bug blocks 2.2r bluetooth feature MAP implementation.
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
|
||
Comment 14•9 years ago
|
||
Hey Ben, this failed to get into 2.2r because there is a conflict:
patching file dom/bluetooth/bluedroid/BluetoothPbapManager.cpp
Hunk #1 FAILED at 3
Hunk #4 FAILED at 475
2 out of 4 hunks FAILED -- saving rejects to file dom/bluetooth/bluedroid/BluetoothPbapManager.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and refresh named-value-22r.patch
could you take a look, thanks!
Flags: needinfo?(btian)
|
|
||
Comment 15•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•