Closed Bug 1195998 Opened 9 years ago Closed 9 years ago

Crash in TextureClient::ForceRemove

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla43
Tracking Flags:
Tracking Status
firefox42 + fixed
firefox43 + fixed

People

(Reporter: bas.schouten, Assigned: bas.schouten)

References

Details

Attachments

(1 file)

Don't call force remove for actors which don't have TextureClients associated
(deleted), patch
nical
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Does this appear like an acceptable fix?
Assignee: nobody → bas
Status: NEW → ASSIGNED
Attachment #8649499 - Flags: review?(nical.bugzilla)
[Tracking Requested - why for this release]: Top 10-crash on Aurora.
status-firefox42: --- → affected
status-firefox43: --- → affected
tracking-firefox42: --- → ?
tracking-firefox43: --- → ?
Attachment #8649499 - Flags: review?(nical.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/ffde34f25611
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Bas, want to request uplift for this ?
tracking-firefox43: ? → +
Flags: needinfo?(bas)
Tracking for 42 too.
tracking-firefox42: ? → +
Milan, I guess we want to uplift that to 42, right? If it is the case, could you fill the uplift request? Thanks
Flags: needinfo?(milan)
Comment on attachment 8649499 [details] [diff] [review] Don't call force remove for actors which don't have TextureClients associated Approval Request Comment [Feature/regressing bug #]: [User impact if declined]: Top crasher on 42 and 43. [Describe test coverage new/current, TreeHerder]: [Risks and why]: Low, a null pointer check. [String/UUID change made/needed]:
Flags: needinfo?(milan)
Flags: needinfo?(bas)
Attachment #8649499 - Flags: approval-mozilla-aurora?
Comment on attachment 8649499 [details] [diff] [review] Don't call force remove for actors which don't have TextureClients associated Thanks Milan. Taking it as it fixes a crash.
Attachment #8649499 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: