Closed Bug 1196350 Opened 9 years ago Closed 9 years ago

Change string in Loop contacts panel to help l10n

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
2

Tracking

(firefox43 verified)

VERIFIED FIXED
mozilla43
Iteration:
43.2 - Sep 7
Tracking Status
firefox43 --- verified

People

(Reporter: andreio, Assigned: andreio)

References

Details

(Whiteboard: [visual refresh])

Attachments

(4 files, 2 obsolete files)

Need: Better strings that can be translated in multiple languages. Context: https://bugzilla.mozilla.org/show_bug.cgi?id=1183615#c28
Assignee: nobody → andrei.br92
Blocks: 1179210
Thanks for filing the bug. While the structure "first sentence, bold font" + "second sentence, smaller font" is already used elsewhere in Hello, in the other cases the two sentences are independent. In this case it's one fully formed sentence split in two parts "No matching results" + "with your search, try again!". Something like "No matching results" + "try again"/"try a new search" would work better for localization.
The string can just be "No matching results". The rest is not necessary. Michael Maslaney will provide a new mockup to communicate this.
Attached image Contact Panel - No Results (deleted) —
Updated mockup from Michael Maslaney showing new string and design attached. Mike, do you mind attaching the asset for the graphic?
Flags: needinfo?(mmaslaney)
No longer blocks: 1183615
Status: NEW → ASSIGNED
Iteration: --- → 43.1 - Aug 24
Points: --- → 2
Depends on: 1183615
Flags: qe-verify+
Flags: firefox-backlog+
Rank: 17
Priority: -- → P1
Whiteboard: [visual refresh]
Iteration: 43.1 - Aug 24 → 43.2 - Sep 7
Flags: needinfo?(mmaslaney)
Attached patch Update contacts view for Loop panel (obsolete) (deleted) — Splinter Review
Attachment #8653942 - Flags: review?(standard8)
Comment on attachment 8653942 [details] [diff] [review] Update contacts view for Loop panel Review of attachment 8653942 [details] [diff] [review]: ----------------------------------------------------------------- The unit tests are currently failing due to the changed string names. I think rather than relying on the strings, we could just check that the "contact-search-list-empty" div is shown. r=Standard8 with the unit tests fixed, unless you want me to look at them again.
Attachment #8653942 - Flags: review?(standard8) → review+
Mmaslaney, would you be able to provide SVG assets here for the empty search panel instead of PNG? Thanks!
Flags: needinfo?(mmaslaney)
(In reply to Mark Banner (:standard8) from comment #6) > Comment on attachment 8653942 [details] [diff] [review] > Update contacts view for Loop panel > > Review of attachment 8653942 [details] [diff] [review]: > ----------------------------------------------------------------- > > The unit tests are currently failing due to the changed string names. I > think rather than relying on the strings, we could just check that the > "contact-search-list-empty" div is shown. > I don't agree. String changes are something we want to catch in tests. It's a good warning that we are not using them and it's either a bug or we should just remove them. Markup changes all the time and not in meaningful ways. Updated the tests but tree is still closed.
Attached patch Update contacts view for Loop panel (obsolete) (deleted) — Splinter Review
Attachment #8653942 - Attachment is obsolete: true
Attached file Hello_Assets_v3.zip (deleted) —
Flags: needinfo?(mmaslaney)
Attachment #8654259 - Attachment is obsolete: true
Attached file Hello_Assets_v4.zip (deleted) —
Updated Assets
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
QA Contact: bogdan.maris
Verified using latest Firefox Developer Edition 43.0a2 across platforms (Windows 7 64-bit, Mac OS X 10.10.5 and Ubuntu 14.04 32-bit) that visual refresh is nicely displayed (according to mockups) along with the string 'No matching results.' when no contact was found matching the users search input.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: