Closed
Bug 1196350
Opened 9 years ago
Closed 9 years ago
Change string in Loop contacts panel to help l10n
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox43 verified)
Tracking | Status | |
---|---|---|
firefox43 | --- | verified |
People
(Reporter: andreio, Assigned: andreio)
References
Details
(Whiteboard: [visual refresh])
Attachments
(4 files, 2 obsolete files)
Need: Better strings that can be translated in multiple languages.
Context: https://bugzilla.mozilla.org/show_bug.cgi?id=1183615#c28
Comment 1•9 years ago
|
||
Thanks for filing the bug.
While the structure "first sentence, bold font" + "second sentence, smaller font" is already used elsewhere in Hello, in the other cases the two sentences are independent.
In this case it's one fully formed sentence split in two parts "No matching results" + "with your search, try again!". Something like "No matching results" + "try again"/"try a new search" would work better for localization.
Comment 2•9 years ago
|
||
The string can just be "No matching results". The rest is not necessary. Michael Maslaney will provide a new mockup to communicate this.
Comment 3•9 years ago
|
||
Updated mockup from Michael Maslaney showing new string and design attached.
Mike, do you mind attaching the asset for the graphic?
Flags: needinfo?(mmaslaney)
Updated•9 years ago
|
Updated•9 years ago
|
Rank: 17
Priority: -- → P1
Whiteboard: [visual refresh]
Updated•9 years ago
|
Iteration: 43.1 - Aug 24 → 43.2 - Sep 7
Comment 4•9 years ago
|
||
Assets can be found here: https://bugzilla.mozilla.org/attachment.cgi?id=8652308&action=edit
Flags: needinfo?(mmaslaney)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8653942 -
Flags: review?(standard8)
Comment 6•9 years ago
|
||
Comment on attachment 8653942 [details] [diff] [review]
Update contacts view for Loop panel
Review of attachment 8653942 [details] [diff] [review]:
-----------------------------------------------------------------
The unit tests are currently failing due to the changed string names. I think rather than relying on the strings, we could just check that the "contact-search-list-empty" div is shown.
r=Standard8 with the unit tests fixed, unless you want me to look at them again.
Attachment #8653942 -
Flags: review?(standard8) → review+
Comment 7•9 years ago
|
||
Mmaslaney, would you be able to provide SVG assets here for the empty search panel instead of PNG?
Thanks!
Flags: needinfo?(mmaslaney)
Assignee | ||
Comment 8•9 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #6)
> Comment on attachment 8653942 [details] [diff] [review]
> Update contacts view for Loop panel
>
> Review of attachment 8653942 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> The unit tests are currently failing due to the changed string names. I
> think rather than relying on the strings, we could just check that the
> "contact-search-list-empty" div is shown.
>
I don't agree. String changes are something we want to catch in tests. It's a good warning that we are not using them and it's either a bug or we should just remove them. Markup changes all the time and not in meaningful ways.
Updated the tests but tree is still closed.
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8653942 -
Attachment is obsolete: true
Flags: needinfo?(mmaslaney)
Assignee | ||
Comment 11•9 years ago
|
||
Attachment #8654259 -
Attachment is obsolete: true
Assignee | ||
Comment 12•9 years ago
|
||
Updated Assets
Comment 14•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•9 years ago
|
QA Contact: bogdan.maris
Comment 15•9 years ago
|
||
Verified using latest Firefox Developer Edition 43.0a2 across platforms (Windows 7 64-bit, Mac OS X 10.10.5 and Ubuntu 14.04 32-bit) that visual refresh is nicely displayed (according to mockups) along with the string 'No matching results.' when no contact was found matching the users search input.
You need to log in
before you can comment on or make changes to this bug.
Description
•