Closed
Bug 1197104
Opened 9 years ago
Closed 9 years ago
[Messages][Drafts] Threadless drafts are broken
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:2.5+, b2g-master verified)
Tracking | Status | |
---|---|---|
b2g-master | --- | verified |
People
(Reporter: azasypkin, Assigned: steveck)
References
Details
(Keywords: regression, Whiteboard: [sms-sprint-FxOS-S5])
Attachments
(2 files)
STR:
* Open Messages app;
* Enter any existing conversation;
* Go back to Inbox;
* Enter New Message view and enter recipient and some message text;
* Go back and save draft;
* Observe Inbox.
Expected result: user should see just saved threadless draft;
Actual result: draft is saved into conversation that user visited on step 2.
It seems the reason is that we don't clean ConversationView.activeThread after patch for bug 1167144. Hence there are other bad consequences of this e.g. New Message header is updated with the text of previously visited conversation in case of contact change and etc.
Reporter | ||
Comment 1•9 years ago
|
||
[Blocking Requested - why for this release]: regression
Steve, can you please take a look?
Thanks!
Comms triage: Functional regression from 2.2.
blocking-b2g: 2.5? → 2.5+
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8650984 [details]
[gaia] steveck-chung:message-remove-threads-dependency > mozilla-b2g:master
Hi Oleg, I think adding the thread clean in beforeleave with current panel checking should be the most appropriate place. Thanks for filing this bug!
Attachment #8650984 -
Flags: review?(azasypkin)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → schung
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8650984 [details]
[gaia] steveck-chung:message-remove-threads-dependency > mozilla-b2g:master
Looks good and thanks for the quick fix! Just one my wish at github :)
Attachment #8650984 -
Flags: review?(azasypkin) → review+
Updated•9 years ago
|
Whiteboard: [sms-sprint-FxOS-S5]
Assignee | ||
Comment 7•9 years ago
|
||
Thanks, I removed the integration test part.
In master: https://github.com/mozilla-b2g/gaia/commit/7a36b3917dfd681a5bcfb78ef5790fc0f2d52fbd
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Target Milestone: --- → FxOS-S6 (04Sep)
Comment 8•9 years ago
|
||
This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.
Actual results: After viewing a thread and backing to save a new draft, user can see the saved draft in messages app.
See attachment: verified_FlameKK_v2.5.3gp
Reproduce rate: 0/10
Device: Flame KK 2.5 (Pass)
Build ID 20150823150207
Gaia Revision cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gaia Date 2015-08-23 03:34:38
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/4ccdd06e51d7209ba429196df7cab97bf66962db
Gecko Version 43.0a1
Device Name flame
Firmware(Release) 4.4.2
Firmware(Incremental) eng.cltbld.20150823.184539
Firmware Date Sun Aug 23 18:45:51 EDT 2015
Firmware Version v18D v4
Bootloader L1TC000118D0
Device: Aries KK 2.5(Pass)
Build ID 20150823221817
Gaia Revision cddb9f610cbe03d0ca39d81bbdce46a0fca841ab
Gaia Date 2015-08-23 03:34:38
Gecko Revision https://hg.mozilla.org/mozilla-central/rev/4ccdd06e51d7209ba429196df7cab97bf66962db
Gecko Version 43.0a1
Device Name aries
Firmware(Release) 4.4.2
Firmware(Incremental) eng.worker.20150823.214038
Firmware Date Sun Aug 23 21:40:46 UTC 2015
Bootloader s1
Comment 9•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•